Bug 58786 - Web Inspector: add test for CSS-resource binding.
Summary: Web Inspector: add test for CSS-resource binding.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-18 07:44 PDT by Pavel Feldman
Modified: 2011-04-18 09:00 PDT (History)
10 users (show)

See Also:


Attachments
Patch (21.90 KB, patch)
2011-04-18 07:47 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff
Patch (21.92 KB, patch)
2011-04-18 08:39 PDT, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-04-18 07:44:37 PDT
Patch to follow.
Comment 1 Pavel Feldman 2011-04-18 07:47:40 PDT
Created attachment 90034 [details]
Patch
Comment 2 Yury Semikhatsky 2011-04-18 08:39:14 PDT
Comment on attachment 90034 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90034&action=review

> LayoutTests/inspector/styles/styles-history-expecte.txt:1
> +Tests resources panel history.

expecte.txt ?
Comment 3 Pavel Feldman 2011-04-18 08:39:57 PDT
Created attachment 90042 [details]
Patch
Comment 4 Yury Semikhatsky 2011-04-18 08:41:33 PDT
Comment on attachment 90034 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90034&action=review

> Source/WebCore/inspector/InspectorStyleSheet.cpp:207
> +            *errorString = "Invalid property value.";

Please remove trailing commas from the error messages.
Comment 5 Alexander Pavlov (apavlov) 2011-04-18 08:52:05 PDT
Comment on attachment 90042 [details]
Patch

Looks good.
Comment 6 Pavel Feldman 2011-04-18 09:00:02 PDT
Committed r84148: <http://trac.webkit.org/changeset/84148>