WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED DUPLICATE of
bug 63318
Bug 58773
[GTK] Release builds should have debug symbols
https://bugs.webkit.org/show_bug.cgi?id=58773
Summary
[GTK] Release builds should have debug symbols
Philippe Normand
Reported
2011-04-18 03:08:43 PDT
To match Mac port nomenclature: --release: build with -O2 -g --production: build with -O2 --debug: build with -O0 -g
Attachments
proposed patch
(3.67 KB, patch)
2011-04-18 03:42 PDT
,
Philippe Normand
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Philippe Normand
Comment 1
2011-04-18 03:41:24 PDT
Production in our case would simply be not Debug and not Release. eg: ./configure --disable-debug --disable-release (both are disabled by default anyway).
Philippe Normand
Comment 2
2011-04-18 03:42:05 PDT
Created
attachment 90011
[details]
proposed patch
Gustavo Noronha (kov)
Comment 3
2011-04-18 05:50:37 PDT
Two points here: * this will make the build take a lot more time, it will possibly be close to a debug build * in Debian we always build with -g anyways, and then split the symbols off to their own package I'm OK with this in principle. I think we should keep the EWS building without -g, though, otherwise it's going to lag heavily.
Philippe Normand
Comment 4
2011-04-18 05:57:02 PDT
For the EWS doing a simple build-webkit --gtk will do a Production build.
Martin Robinson
Comment 5
2011-04-18 08:14:27 PDT
Comment on
attachment 90011
[details]
proposed patch I think the debug, release, production terminology might be unusual to people familiar with configure, make, make install. Maybe it would make sense to have the configure flag something like --enable-debug-symbols or even just override the CPPFLAGS manually. What do you think?
Philippe Normand
Comment 6
2011-04-18 08:35:08 PDT
(In reply to
comment #5
)
> (From update of
attachment 90011
[details]
) > I think the debug, release, production terminology might be unusual to people familiar with configure, make, make install. Maybe it would make sense to have the configure flag something like --enable-debug-symbols
hum yes make sense indeed! I'll upload a new patch
> or even just override the CPPFLAGS manually. What do you think?
Not sure that would integrate well with build-webkit...
Philippe Normand
Comment 7
2011-04-19 09:47:27 PDT
(In reply to
comment #1
)
> Production in our case would simply be not Debug and not Release. eg: ./configure --disable-debug --disable-release (both are disabled by default anyway).
That was a wrong assumption, the default build configuration is Release. Meaning that by default dbg symbols would be included. So not sure what to do to have a build without dbg symbols using build-webkit. I don't think setting CXXFLAGS manually would work because build-webkit when calling configure would anyway insert the -g switch there. On mac the build configuration can be changed by a Configuration file the product directory. But that doesn't feel very intuitive (IMHO). I think that leaves us with a new build-webkit option, --production maybe? That would enable build with optimizations and without dbg symbols. Opinions?
Philippe Normand
Comment 8
2011-06-27 01:55:05 PDT
*** This bug has been marked as a duplicate of
bug 63318
***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug