Web Inspector: Backspace in the Console is broken

[Alexander Pavlov (apavlov)]

This is a regression from http://trac.webkit.org/changeset/83968

[Alexander Pavlov (apavlov)]

Created attachment 90002 [details]
[PATCH] Suggested fix

[Yury Semikhatsky]

Comment on attachment 90002 [details]
[PATCH] Suggested fix

View in context: https://bugs.webkit.org/attachment.cgi?id=90002&action=review

> Source/WebCore/inspector/front-end/inspector.js:797
> +            if (!selection.rangeCount || !selection.isCollapsed)

This will break backspace on non-empty selection. r- for this.

[Alexander Pavlov (apavlov)]

Created attachment 90043 [details]
[PATCH] A proper fix that only inhibits Backspace default handling for -webkit-user-modify: read-only elements

[Yury Semikhatsky]

Comment on attachment 90043 [details]
[PATCH] A proper fix that only inhibits Backspace default handling for -webkit-user-modify: read-only elements

View in context: https://bugs.webkit.org/attachment.cgi?id=90043&action=review

> Source/WebCore/inspector/front-end/inspector.js:797
> +                var computedStyle = document.defaultView.getComputedStyle(this.currentFocusElement, null, "");

Could you provide a comment explaining this logic?

[Alexander Pavlov (apavlov)]

Committed r84150: <http://trac.webkit.org/changeset/84150>

[WebKit Review Bot]

http://trac.webkit.org/changeset/84150 might have broken GTK Linux 32-bit Debug

[Alexander Pavlov (apavlov)]

Rolled out in r84236.