RESOLVED FIXED 58754
new-run-webkit-tests: obsolete old code, part 3 - rename test_runner to manager 
https://bugs.webkit.org/show_bug.cgi?id=58754
Summary new-run-webkit-tests: obsolete old code, part 3 - rename test_runner to manager
Dirk Pranke
Reported 2011-04-17 16:33:24 PDT
new-run-webkit-tests: obsolete old code, part 3 - rename test_runner to manager
Attachments
Patch (6.06 KB, patch)
2011-04-17 16:37 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
add raw patch to pick up the rename (131.71 KB, patch)
2011-04-17 17:19 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
rebase to HEAD (67.47 KB, patch)
2011-04-21 20:13 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
raw git diff of patch, to pick up the rename, rebased to HEAD (67.12 KB, patch)
2011-04-21 20:19 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
try again with the patch (128.72 KB, patch)
2011-04-21 20:24 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2011-04-17 16:37:58 PDT
Created attachment 89970 [details] Patch
Dirk Pranke
Comment 2 2011-04-17 16:58:30 PDT
This is all cut&paste, there should be no real changes here.
Dirk Pranke
Comment 3 2011-04-17 16:59:42 PDT
Oh, and for reasons I don't understand (a bug?) webkit-patch and/or pretty-diff are not picking up on test_runner.py being renamed to manager.py, so imagine that is happening in the diff (for both test_runner and test_runner_unittest).
Dirk Pranke
Comment 4 2011-04-17 17:19:01 PDT
Created attachment 89977 [details] add raw patch to pick up the rename
Dirk Pranke
Comment 5 2011-04-17 17:19:40 PDT
Okay, I've posted the raw git diff, which appears to be fine.
Eric Seidel (no email)
Comment 6 2011-04-17 17:43:28 PDT
This may be the changed_files optimization in webkit-patch biting us.
Tony Chang
Comment 7 2011-04-19 09:29:08 PDT
Comment on attachment 89977 [details] add raw patch to pick up the rename OK
Dirk Pranke
Comment 8 2011-04-21 20:13:37 PDT
Created attachment 90656 [details] rebase to HEAD
Dirk Pranke
Comment 9 2011-04-21 20:19:53 PDT
Created attachment 90658 [details] raw git diff of patch, to pick up the rename, rebased to HEAD
Dirk Pranke
Comment 10 2011-04-21 20:24:38 PDT
Created attachment 90660 [details] try again with the patch
Dirk Pranke
Comment 11 2011-04-21 20:27:00 PDT
Committed r84594: <http://trac.webkit.org/changeset/84594>
Note You need to log in before you can comment on or make changes to this bug.