Bug 58754 - new-run-webkit-tests: obsolete old code, part 3 - rename test_runner to manager
Summary: new-run-webkit-tests: obsolete old code, part 3 - rename test_runner to manager
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on: 58753
Blocks: 58756
  Show dependency tree / graph
 
Reported: 2011-04-17 16:33 PDT by Dirk Pranke
Modified: 2011-04-21 20:27 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.06 KB, patch)
2011-04-17 16:37 PDT, Dirk Pranke 		no flags Details | Formatted Diff | Diff
add raw patch to pick up the rename (131.71 KB, patch)
2011-04-17 17:19 PDT, Dirk Pranke 		no flags Details | Formatted Diff | Diff
rebase to HEAD (67.47 KB, patch)
2011-04-21 20:13 PDT, Dirk Pranke 		no flags Details | Formatted Diff | Diff
raw git diff of patch, to pick up the rename, rebased to HEAD (67.12 KB, patch)
2011-04-21 20:19 PDT, Dirk Pranke 		no flags Details | Formatted Diff | Diff
try again with the patch (128.72 KB, patch)
2011-04-21 20:24 PDT, Dirk Pranke 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2011-04-17 16:33:24 PDT 
new-run-webkit-tests: obsolete old code, part 3 - rename test_runner to manager
Comment 1 Dirk Pranke 2011-04-17 16:37:58 PDT 
Created attachment 89970 [details]
Patch
Comment 2 Dirk Pranke 2011-04-17 16:58:30 PDT 
This is all cut&paste, there should be no real changes here.
Comment 3 Dirk Pranke 2011-04-17 16:59:42 PDT 
Oh, and for reasons I don't understand (a bug?) webkit-patch and/or pretty-diff are not picking up on test_runner.py being renamed to manager.py, so imagine that is happening in the diff (for both test_runner and test_runner_unittest).
Comment 4 Dirk Pranke 2011-04-17 17:19:01 PDT 
Created attachment 89977 [details]
add raw patch to pick up the rename
Comment 5 Dirk Pranke 2011-04-17 17:19:40 PDT 
Okay, I've posted the raw git diff, which appears to be fine.
Comment 6 Eric Seidel (no email) 2011-04-17 17:43:28 PDT 
This may be the changed_files optimization in webkit-patch biting us.
Comment 7 Tony Chang 2011-04-19 09:29:08 PDT 
Comment on attachment 89977 [details]
add raw patch to pick up the rename

OK
Comment 8 Dirk Pranke 2011-04-21 20:13:37 PDT 
Created attachment 90656 [details]
rebase to HEAD
Comment 9 Dirk Pranke 2011-04-21 20:19:53 PDT 
Created attachment 90658 [details]
raw git diff of patch, to pick up the rename, rebased to HEAD
Comment 10 Dirk Pranke 2011-04-21 20:24:38 PDT 
Created attachment 90660 [details]
try again with the patch
Comment 11 Dirk Pranke 2011-04-21 20:27:00 PDT 
Committed r84594: <http://trac.webkit.org/changeset/84594>