Bug 58746 – Move WebNodeHighlighter into its own file

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Joseph Pecoraro]

Extract this class into its own file.

[Joseph Pecoraro]

Created attachment 89958 [details]
[PATCH] Extract into its own file

Some minor cleanup in the process:

  - fix WebInspectorClient constructor
  - remove "WebNodeHightlighter delegate" methods on WebInspectorWindowController
    which were never called because it was never set to be the delegate.
  - added [super init] boilerplate to WebNodeHighligher's constructor

Also, the ObjC classes in WebInspectorClient don't properly initialize self.
They just call the super methods but don't assign to self. Should I fix those
up as well?

[Joseph Pecoraro]

Created attachment 89959 [details]
[PATCH] Extract into its own file

Fixed a typo in the ChangeLog.

[Timothy Hatcher]

Comment on attachment 89958 [details]
[PATCH] Extract into its own file

View in context: https://bugs.webkit.org/attachment.cgi?id=89958&action=review

> Source/WebKit/mac/WebInspector/WebNodeHighlighter.mm:42
> +    self = [super init];
> +    if (!self)
> +        return nil;

I like this form:

if (!(self = [super init]))
    return nil;

[Joseph Pecoraro]

I like this form:
> 
> if (!(self = [super init]))
>     return nil;

Gross! But acceptable. =)

Should I open up a new bug and do the same for -[WebInspectorWindowController init]
and -[WebInspectorWindowController initWithWebView]?

[Timothy Hatcher]

Sure.

[Joseph Pecoraro]

Landed in <http://trac.webkit.org/changeset/84108>.