Bug 58723 - show diffs+test inline in the results page
Summary: show diffs+test inline in the results page
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on: 58715
Blocks:
  Show dependency tree / graph
 
Reported: 2011-04-15 21:12 PDT by Ojan Vafai
Modified: 2011-04-16 02:33 PDT (History)
2 users (show)

See Also:

Attachments
Patch (7.88 KB, patch)
2011-04-15 21:13 PDT, Ojan Vafai 		no flags Details | Formatted Diff | Diff
screenshot (85.74 KB, image/png)
2011-04-15 21:15 PDT, Ojan Vafai 		no flags Details
screenshot diffs expanded (147.77 KB, image/png)
2011-04-15 21:15 PDT, Ojan Vafai 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2011-04-15 21:12:05 PDT 
show diffs+test inline in the results page
Comment 1 Ojan Vafai 2011-04-15 21:13:50 PDT 
Created attachment 89908 [details]
Patch
Comment 2 Ojan Vafai 2011-04-15 21:15:21 PDT 
Created attachment 89909 [details]
screenshot
Comment 3 Ojan Vafai 2011-04-15 21:15:35 PDT 
Created attachment 89910 [details]
screenshot diffs expanded
Comment 4 Eric Seidel (no email) 2011-04-15 22:55:51 PDT 
Comment on attachment 89908 [details]
Patch

I think those may need labels. :)
Comment 5 Ojan Vafai 2011-04-15 23:15:40 PDT 
(In reply to comment #4)
> I think those may need labels. :)

Yup. There's a FIXME for that.
Comment 6 WebKit Commit Bot 2011-04-16 02:33:21 PDT 
Comment on attachment 89908 [details]
Patch

Clearing flags on attachment: 89908

Committed r84086: <http://trac.webkit.org/changeset/84086>
Comment 7 WebKit Commit Bot 2011-04-16 02:33:27 PDT 
All reviewed patches have been landed.  Closing bug.