Bug 58719 – Cancelling fullscreen doesn't properly reset internal state

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Andrew Scherkus]

Root problem is m_fullscreenElement remains non-null, which means webkitIsFullScreen() returns false but webkitCurrentFullScreenElement() returns the old (and I think detached!) element and a successive call to webkitCancelFullScreen() results in all sorts of bad stuff.

[Andrew Scherkus]

Created attachment 89899 [details]
Patch

[Adam Barth]

Comment on attachment 89899 [details]
Patch

I'm impressed that this patch is almost all minus lines, but I don't understand how this code works well enough to review your patch.

[Andrew Scherkus]

Sorry for combining clean-up with a bug fix :(

In essence the fix is a one-liner: the addition of "m_fullScreenElement = 0" to webkitDidExitFullScreen

Technically m_isFullScreen should have guarded against being able to re-cancel full screen (see Document::webkitCancelFullScreen), but because we only check m_fullScreenElement, we execute the cancel code again and Bad Things happen.

Instead of having both m_isFullScreen and m_fullScreenElement track whether Document is in full screen, it seems safer to rely on whether m_fullScreenElement set.

[Jer Noble]

Looks good to me.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 89899 [details]:

animations/suspend-resume-animation.html bug 48161 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 89899 [details]
Patch

Rejecting attachment 89899 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'land-a..." exit_code: 2

Last 500 characters of output:
lay your work on top of it...
Fast-forwarded master to refs/remotes/trunk.
Updating OpenSource
From git://git.webkit.org/WebKit
   e625813..122c5ca  master     -> origin/master
	M	LayoutTests/platform/qt/Skipped
	M	LayoutTests/ChangeLog
	M	Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp
	M	Source/WebKit/qt/ChangeLog
r84168 = 122c5ca6e727a26fcffb5ef048533f56183e5a2e (refs/remotes/trunk)
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/trunk.

Full output: http://queues.webkit.org/results/8469061

[WebKit Review Bot]

http://trac.webkit.org/changeset/84169 might have broken Qt Linux Release
The following tests are not passing:
fast/ruby/after-block-doesnt-crash.html
fast/ruby/after-table-doesnt-crash.html
fast/ruby/before-block-doesnt-crash.html
fast/ruby/before-table-doesnt-crash.html

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 89899 [details]:

http/tests/xmlhttprequest/re-login-async.html bug 51763 (author: [e-mail])
The commit-queue is continuing to process your patch.