RESOLVED FIXED58716
JavaScriptCore shouldn't depend on ../ThirdParty/gtest/xcode/gtest.xcodeproj 
https://bugs.webkit.org/show_bug.cgi?id=58716
Summary JavaScriptCore shouldn't depend on ../ThirdParty/gtest/xcode/gtest.xcodeproj
Timothy Hatcher
Reported 2011-04-15 17:31:50 PDT
In https://trac.webkit.org/changeset/83974 JavaScriptCore became dependant on an external project. This breaks the build under Apple's internal build system. In general anthing inside Source/JavaScriptCore (and WebCore, etc.) can't reference something outside that source root. So ../ThirdParty is a violation of that.
Attachments
Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2011-04-15 17:34:06 PDT
The correct way to do this would be to build gtest and have JSC depend on it and link against it. Like WebCore does with ANGLE.
Timothy Hatcher
Comment 2 2011-04-15 17:40:47 PDT
Mark Rowe has told me the build still works. But this is still not the normal way we do cross project dependancy in WebKit.
Mark Rowe (bdash)
Comment 3 2011-04-15 17:44:48 PDT
I think this change should be reverted. JavaScriptCore.xcodeproj isn’t the right place for this to live. JavaScriptCore.xcodeproj should not depend on this random third-party library.
Adam Barth
Comment 4 2011-04-15 17:50:59 PDT
Does this mean that the entire Source directory exists when JavaScript.xcodeproj is built?
Mark Rowe (bdash)
Comment 5 2011-04-15 17:52:37 PDT
(In reply to comment #4) > Does this mean that the entire Source directory exists when JavaScript.xcodeproj is built? Does what mean that?
Timothy Hatcher
Comment 6 2011-04-15 17:55:43 PDT
No, only the JavaScriptCore source tree exists when JavaScriptCore is built.
Timothy Hatcher
Comment 7 2011-04-15 17:58:39 PDT
The build does not fail like I thought it did only because the All target does not build the wtftests target. If it did, it would fail because the gtest project can't be found.
David Levin
Comment 8 2011-04-15 18:00:03 PDT
I'm working on rolling this out.
Adam Barth
Comment 9 2011-04-15 18:12:04 PDT
> > Does this mean that the entire Source directory exists when JavaScript.xcodeproj is built? > > Does what mean that? I was trying to understand why this didn't break the build entirely. Comment #7 has the answer.
David Levin
Comment 10 2011-04-15 18:17:42 PDT
Committed as http://trac.webkit.org/changeset/84068
WebKit Review Bot
Comment 11 2011-04-15 19:28:54 PDT
http://trac.webkit.org/changeset/84068 might have broken Windows 7 Release (Tests) The following tests are not passing: http/tests/inspector/resource-tree-model.html
Note You need to log in before you can comment on or make changes to this bug.