Bug 58693 – REGRESSION: <progress> doesn't animate if it doesn't have value

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Hajime Morrita]

The indefinite progress bar, which is rendered by <progress> element without value property should animate.
Looks introduced http://trac.webkit.org/changeset/83065.

[Hajime Morrita]

Created attachment 89862 [details]
Patch

[Yael]

Thanks for fixing it.

[Adam Barth]

Comment on attachment 89862 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89862&action=review

Nice patch.  Yay for named constants.

> Source/WebCore/ChangeLog:12
> +        No new tests. Testing animated bar is not possible with DRT.

Frown.  This likely means we will continue to have regressions.

[Kent Tamura]

Comment on attachment 89862 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89862&action=review

> Source/WebCore/html/HTMLProgressElement.cpp:43
> +const double HTMLProgressElement::IndeterminatePosition = -1;
> +const double HTMLProgressElement::InvalidPosition = -2;

In RenderProgress::isDeterminate(), we should use these named constants, or add a comment that "0 <= " means neither indeterminate nor invalid.

[Hajime Morrita]

Adam, Kent-san, thank you for reviewing!
I'll land this with addressing Kent-san's point.

[Hajime Morrita]

Committed r84156: <http://trac.webkit.org/changeset/84156>

[WebKit Review Bot]

http://trac.webkit.org/changeset/84156 might have broken GTK Linux 32-bit Debug