Bug 58692 – old-run-webkit-tests: save the list of tests actually run to a file

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dirk Pranke]

old-run-webkit-tests: save the list of tests actually run to a file

[Dirk Pranke]

Created attachment 89849 [details]
Patch

[Dirk Pranke]

I don't actually care that much whether we land this or not, I'm just posting it in case other people might find it useful.

[Eric Seidel (no email)]

Comment on attachment 89849 [details]
Patch

I think this could be quite useful, honestly.  Does NRWT do similar?

[Dirk Pranke]

(In reply to comment #3)
> (From update of attachment 89849 [details])
> I think this could be quite useful, honestly.  Does NRWT do similar?

Yes, NRWT saves a list per-worker.

[WebKit Commit Bot]

Comment on attachment 89849 [details]
Patch

Clearing flags on attachment: 89849

Committed r84076: <http://trac.webkit.org/changeset/84076>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

I think it is a useful feature for debugging, but 
we can get similar list on stdout with -v option.

I have two minor problems with it:

- ~ 3Mb sized list file for every build is hard disk killer on buildbot masters
It would be better to make this feature optional,or upload gzipped list.(~130Kb)

- absolute path: Why do we use absolute paths in this list? I think relative paths to LayoutTests directory is more than enough.

Reopen to discuss about my proposed changes.

[Eric Seidel (no email)]

I like both of those suggestions.  Just putting it behind a flag seems reasonable.

[Ojan Vafai]

(In reply to comment #8)
> I like both of those suggestions.  Just putting it behind a flag seems reasonable.

Noooo. We have way too many flags already. There's no reason to store the absolute path. I expect storing relative paths will be enough to make this file reasonably sized. If not that, writing out the zipped file is surely sufficient.

[Dirk Pranke]

I have no objection to either flags or shorter paths. I wouldn't bother gzipping the list. Or, feel free to revert it, even. We've made it this long without it :)

[Dirk Pranke]

Csaba, do you have an opinion on whether just relative paths but not a gzipped list would be sufficient?

[Dirk Pranke]

I'm going to close this due to lack of comments and post a separate patch that shortens the list to relative paths and call it a day. See bug 62751 for the patch.