Bug 58690 - new-run-webkit-tests: save stderr into the layout-test-results dir
Summary: new-run-webkit-tests: save stderr into the layout-test-results dir
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on: 58770
Blocks: 37739
  Show dependency tree / graph
 
Reported: 2011-04-15 13:49 PDT by Dirk Pranke
Modified: 2011-04-18 12:52 PDT (History)
1 user (show)

See Also:

Attachments
Patch (3.00 KB, patch)
2011-04-15 13:50 PDT, Dirk Pranke 		ojan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2011-04-15 13:49:55 PDT 
new-run-webkit-tests: save stderr into the layout-test-results dir
Comment 1 Dirk Pranke 2011-04-15 13:50:27 PDT 
Created attachment 89846 [details]
Patch
Comment 2 Dirk Pranke 2011-04-15 13:51:24 PDT 
Splitting the saving of the error text out from the display of it (which I'll let Ojan fix in the original bug).
Comment 3 David Levin 2011-04-15 13:56:25 PDT 
Comment on attachment 89846 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89846&action=review

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:341
>          tests_run = get_tests_run(['failures/expected/keybaord.html'], tests_included=True, flatten_batches=True)

btw, typo: keybaord

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:348
> +                          'stuff going to stderr')

What makes the file contain "stuff going to stderr"?
Comment 4 Dirk Pranke 2011-04-15 14:02:06 PDT 
(In reply to comment #3)
> (From update of attachment 89846 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=89846&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:341
> >          tests_run = get_tests_run(['failures/expected/keybaord.html'], tests_included=True, flatten_batches=True)
> 
> btw, typo: keybaord
>

Interesting. I'll fix that in a different bug.
 
> > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:348
> > +                          'stuff going to stderr')
> 
> What makes the file contain "stuff going to stderr"?

That is done at port/test.py:147, which has custom logic to fake output going to stderr for that particular test. That code has been there forever.
Comment 5 Ojan Vafai 2011-04-15 14:04:00 PDT 
Comment on attachment 89846 [details]
Patch

Does this mean we're writing stderr into the test and into the stderr.txt? We should only be doing the latter. Fine with that being part of this patch or a separate patch though.
Comment 6 Dirk Pranke 2011-04-15 14:09:27 PDT 
H(In reply to comment #5)
> (From update of attachment 89846 [details])
> Does this mean we're writing stderr into the test and into the stderr.txt? We should only be doing the latter. Fine with that being part of this patch or a separate patch though.

Hm. Good point, I had forgotten that the chromium ports were doing that. I'll fix that in a separate patch.
Comment 7 Dirk Pranke 2011-04-17 14:49:47 PDT 
Committed r84112: <http://trac.webkit.org/changeset/84112>
Comment 8 Dirk Pranke 2011-04-18 11:08:25 PDT 
grr. I don't know why I spaced and committed this yesterday w/o updating the baselines.

This was rolled back in r84127 / bug 58690.
Comment 9 Dirk Pranke 2011-04-18 12:52:25 PDT 
double-grr: comment #8 applies to bug 58708, not this bug. This patch was fine and didn't need to be rolled out.