Bug 58679 - The GTest framework should not use MacOSX10.4u.sdk
Summary: The GTest framework should not use MacOSX10.4u.sdk
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-15 11:58 PDT by Timothy Hatcher
Modified: 2012-10-16 22:07 PDT (History)
3 users (show)

See Also:


Attachments
Fixing gtest configuration (3.38 KB, patch)
2011-04-15 14:14 PDT, Dmitry Lomov
levin: review-
Details | Formatted Diff | Diff
Fixing gtest configuration (3.89 KB, patch)
2011-04-15 14:45 PDT, Dmitry Lomov
levin: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2011-04-15 11:58:35 PDT
Using it causes warnings on systems that don't have $(DEVELOPER_SDK_DIR)/MacOSX10.4u.sdk. It should not have an SDK and use the current system.
Comment 1 Timothy Hatcher 2011-04-15 12:07:34 PDT
Using GCC_VERSION = 4.0 is also a warning.
Comment 2 David Levin 2011-04-15 12:47:05 PDT
Dimitry is working on this shortly (today). If this is causing you grief, feel free to roll out r83974 and it can be put back with an appropriate fix.
Comment 3 Dmitry Lomov 2011-04-15 14:14:24 PDT
Created attachment 89851 [details]
Fixing gtest configuration

    Modified definitions for SDKPATH and GCC_VERSION in Source/ThirdParty/gtest/xcode/Config/General.xcconfig to:
      * bring them in line with the rest of WebKit
      * not require MacOS 10.4 SDK and gcc 4.0
    Dropped support of ppc and ppc64 for checked-in GTest
Comment 4 David Levin 2011-04-15 14:17:22 PDT
Comment on attachment 89851 [details]
Fixing gtest configuration

View in context: https://bugs.webkit.org/attachment.cgi?id=89851&action=review

README.WebKit is good but you still need a ChangeLog.

> Source/ThirdParty/gtest/xcode/Config/General.xcconfig:39
> +// number.  Newer versions of Xcode use XCODE_VERSION_MINOR for the minor version, and

Single space after . for WebKit.

> Source/ThirdParty/gtest/xcode/Config/General.xcconfig:63
> +// If the target Mac OS X version does not match the current Mac OS X version then we'll want to build using the target version's SDK.

Add , before then.
Comment 5 Dmitry Lomov 2011-04-15 14:45:43 PDT
Created attachment 89858 [details]
Fixing gtest configuration

CR feedback addressed
Comment 6 David Levin 2011-04-15 17:53:12 PDT
Comment on attachment 89858 [details]
Fixing gtest configuration

Rolling out the change that this depends on.
Comment 7 Eric Seidel (no email) 2012-10-16 22:07:51 PDT
Looks like this got forgotten?  Or maybe silently fixed?