Bug 58677 – globalObject moved to JSObjectWithGlobalObject.cpp inhibits inlining

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Michael Saboff]

Created attachment 89824 [details]
Patch to move globalObject() to JSObjectWithGlobalObject.h

As part of r60057, globalObject() was moved from JSDOMBinding.h to JSObjectWithGlobalObject.cpp.  This limits a compilers ability to inline, especially in other components, namely WebCore.  This is causing a performance regression.

Moving globalObject() back to a .h file is worth ~5% on the dromaeo DOM benchmark.

[WebKit Review Bot]

Attachment 89824 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Michael Saboff]

Created attachment 89835 [details]
Updated patch with bug reference in ChangeLog

[Mark Rowe (bdash)]

Comment on attachment 89835 [details]
Updated patch with bug reference in ChangeLog

“equivolent”

[Oliver Hunt]

Comment on attachment 89835 [details]
Updated patch with bug reference in ChangeLog

r=me

[Jeff Miller]

Comment on attachment 89835 [details]
Updated patch with bug reference in ChangeLog

View in context: https://bugs.webkit.org/attachment.cgi?id=89835&action=review

> Source/JavaScriptCore/ChangeLog:10
> +        it for a performance benefit.  An equivolent instance had been in

Typo - equivolent

[Michael Saboff]

Committed r84030: <http://trac.webkit.org/changeset/84030>

[Michael Saboff]

Note that I fixed the "equivalent" typo before landing the patch.

[WebKit Review Bot]

http://trac.webkit.org/changeset/84030 might have broken WinCE Release (Build)