Bug 58674 - JSC InjectedScriptHost::nodeAsScriptValue should take JSLock before possible JavaScript Allocations
Summary: JSC InjectedScriptHost::nodeAsScriptValue should take JSLock before possible ...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2011-04-15 10:53 PDT by Joseph Pecoraro
Modified: 2011-04-15 13:02 PDT (History)
3 users (show)

See Also:

[PATCH] Proposed Fix (1.37 KB, patch)
2011-04-15 12:34 PDT, Joseph Pecoraro
ddkilzer: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2011-04-15 10:53:00 PDT
Possible JavaScript Allocation in the toJS call so we should take the JSLock beforehand:
      ScriptValue InjectedScriptHost::nodeAsScriptValue(ScriptState* state, Node* node)
          return ScriptValue(state->globalData(), toJS(state, node));

Path to follow.
Comment 1 Joseph Pecoraro 2011-04-15 12:34:06 PDT
Created attachment 89829 [details]
[PATCH] Proposed Fix
Comment 2 David Kilzer (:ddkilzer) 2011-04-15 12:39:16 PDT
Comment on attachment 89829 [details]
[PATCH] Proposed Fix

Comment 3 Joseph Pecoraro 2011-04-15 13:02:25 PDT