Bug 58670 - hide unused static function when SKIA_GPU is enabled
Summary: hide unused static function when SKIA_GPU is enabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Mike Reed
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-15 10:12 PDT by Mike Reed
Modified: 2011-04-15 18:19 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.47 KB, patch)
2011-04-15 10:14 PDT, Mike Reed
fishd: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Reed 2011-04-15 10:12:52 PDT
hide unused static function when SKIA_GPU is enabled
Comment 1 Mike Reed 2011-04-15 10:14:01 PDT
Created attachment 89801 [details]
Patch
Comment 2 Mike Reed 2011-04-15 10:15:42 PDT
This local function is not referenced when SKIA_GPU is enabled, and so we get a warning (which we treat as an error). This is just to address that warning: there is no functional change.
Comment 3 WebKit Commit Bot 2011-04-15 11:46:41 PDT
Comment on attachment 89801 [details]
Patch

Rejecting attachment 89801 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'land-a..." exit_code: 1

Last 500 characters of output:
autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain
    result = func(*args)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open
    return self.do_open(conn_factory, req)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open
    raise URLError(err)
urllib2.URLError: <urlopen error [Errno 60] Operation timed out>

Full output: http://queues.webkit.org/results/8459206
Comment 4 Kenneth Russell 2011-04-15 12:09:14 PDT
This actually landed as http://trac.webkit.org/changeset/84000 , but the update of the bug failed. Closing it manually.
Comment 5 WebKit Review Bot 2011-04-15 18:19:18 PDT
http://trac.webkit.org/changeset/84000 might have broken GTK Linux 32-bit Debug
The following tests are not passing:
svg/W3C-SVG-1.1/animate-elem-82-t.svg