Bug 58668 - Web Inspector: introduce WorkerInspectorController
Summary: Web Inspector: introduce WorkerInspectorController
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks: 58541
  Show dependency treegraph
 
Reported: 2011-04-15 08:42 PDT by Yury Semikhatsky
Modified: 2011-04-18 04:05 PDT (History)
13 users (show)

See Also:


Attachments
Patch (25.29 KB, patch)
2011-04-15 09:34 PDT, Yury Semikhatsky
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2011-04-15 08:42:02 PDT
As described in bug 58541 to support worker inspection we will need a class that would hold all inspector agents for the inspected WorkerContext.
Comment 1 Yury Semikhatsky 2011-04-15 09:34:11 PDT
Created attachment 89796 [details]
Patch
Comment 2 Pavel Feldman 2011-04-18 02:10:50 PDT
Comment on attachment 89796 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89796&action=review

> Source/WebCore/inspector/WorkerInspectorController.cpp:107
> +        0,

What does it mean? :) Could you comment on agent names?
Comment 3 Yury Semikhatsky 2011-04-18 02:21:18 PDT
(In reply to comment #2)
> (From update of attachment 89796 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=89796&action=review
> 
> > Source/WebCore/inspector/WorkerInspectorController.cpp:107
> > +        0,
> 
> What does it mean? :) Could you comment on agent names?
Done.
Comment 4 Yury Semikhatsky 2011-04-18 02:28:29 PDT
Committed r84125: <http://trac.webkit.org/changeset/84125>
Comment 5 WebKit Review Bot 2011-04-18 04:05:49 PDT
http://trac.webkit.org/changeset/84125 might have broken GTK Linux 64-bit Debug