Bug 58667 – [GTK] editing/selection/select-out-of-editable.html failing after r83967

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Sergio Villar Senin]

The diff:

--- /home/slave/webkitgtk/gtk-linux-32-debug/build/layout-test-results/editing/selection/select-out-of-editable-expected.txt	2011-04-15 07:06:09.978467441 -0700
+++ /home/slave/webkitgtk/gtk-linux-32-debug/build/layout-test-results/editing/selection/select-out-of-editable-actual.txt	2011-04-15 07:06:09.959742392 -0700
@@ -1,4 +1,4 @@
 hello world
-Dragging to the left: PASS
-Dragging to the left: PASS
+Dragging to the left: FAIL - expected 0 but got 7
+Dragging to the left: FAIL - expected 11 but got 10

I'll skip it for the moment.

[Sergio Villar Senin]

Committed r83979: <http://trac.webkit.org/changeset/83979>

[Martin Robinson]

The issue here seems to be that triggering another mouseDown event while the mouse button is already down can interfere with drags in Xvfb.

[Martin Robinson]

Created attachment 90406 [details]
Patch

[Xan Lopez]

Comment on attachment 90406 [details]
Patch

We need to check that the button we are getting now is the same one that was already pressed.

[Martin Robinson]

Created attachment 91249 [details]
Updated patch with improved ChangeLog

[Martin Robinson]

(In reply to comment #4)
> (From update of attachment 90406 [details])
> We need to check that the button we are getting now is the same one that was already pressed.

Thanks for the review. I've updated the patch to allow consecutive mouse down events from different buttons and verified that it passes Daniel's test for this issue.(In reply to comment #0)
> The diff:
> 
> --- /home/slave/webkitgtk/gtk-linux-32-debug/build/layout-test-results/editing/selection/select-out-of-editable-expected.txt    2011-04-15 07:06:09.978467441 -0700
> +++ /home/slave/webkitgtk/gtk-linux-32-debug/build/layout-test-results/editing/selection/select-out-of-editable-actual.txt    2011-04-15 07:06:09.959742392 -0700
> @@ -1,4 +1,4 @@
>  hello world
> -Dragging to the left: PASS
> -Dragging to the left: PASS
> +Dragging to the left: FAIL - expected 0 but got 7
> +Dragging to the left: FAIL - expected 11 but got 10
> 
> I'll skip it for the moment.

[Eric Seidel (no email)]

Comment on attachment 91249 [details]
Updated patch with improved ChangeLog

View in context: https://bugs.webkit.org/attachment.cgi?id=91249&action=review

> Tools/DumpRenderTree/gtk/EventSender.cpp:65
> +static unsigned int buttonCurrentlyDown;

unsigned is all you need, not "int".

[Martin Robinson]

Comment on attachment 91249 [details]
Updated patch with improved ChangeLog

Clearing flags on attachment: 91249

Committed r85481: <http://trac.webkit.org/changeset/85481>

[Martin Robinson]

All reviewed patches have been landed.  Closing bug.