Bug 58667 - [GTK] editing/selection/select-out-of-editable.html failing after r83967
Summary: [GTK] editing/selection/select-out-of-editable.html failing after r83967
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-15 08:38 PDT by Sergio Villar Senin
Modified: 2011-05-02 09:23 PDT (History)
1 user (show)

See Also:

Attachments
Patch (2.91 KB, patch)
2011-04-20 14:04 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
Updated patch with improved ChangeLog (3.25 KB, patch)
2011-04-27 00:45 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2011-04-15 08:38:53 PDT 
The diff:

--- /home/slave/webkitgtk/gtk-linux-32-debug/build/layout-test-results/editing/selection/select-out-of-editable-expected.txt	2011-04-15 07:06:09.978467441 -0700
+++ /home/slave/webkitgtk/gtk-linux-32-debug/build/layout-test-results/editing/selection/select-out-of-editable-actual.txt	2011-04-15 07:06:09.959742392 -0700
@@ -1,4 +1,4 @@
 hello world
-Dragging to the left: PASS
-Dragging to the left: PASS
+Dragging to the left: FAIL - expected 0 but got 7
+Dragging to the left: FAIL - expected 11 but got 10

I'll skip it for the moment.
Comment 1 Sergio Villar Senin 2011-04-15 08:45:26 PDT 
Committed r83979: <http://trac.webkit.org/changeset/83979>
Comment 2 Martin Robinson 2011-04-20 14:02:58 PDT 
The issue here seems to be that triggering another mouseDown event while the mouse button is already down can interfere with drags in Xvfb.
Comment 3 Martin Robinson 2011-04-20 14:04:05 PDT 
Created attachment 90406 [details]
Patch
Comment 4 Xan Lopez 2011-04-26 12:02:43 PDT 
Comment on attachment 90406 [details]
Patch

We need to check that the button we are getting now is the same one that was already pressed.
Comment 5 Martin Robinson 2011-04-27 00:45:58 PDT 
Created attachment 91249 [details]
Updated patch with improved ChangeLog
Comment 6 Martin Robinson 2011-04-27 00:46:56 PDT 
(In reply to comment #4)
> (From update of attachment 90406 [details])
> We need to check that the button we are getting now is the same one that was already pressed.

Thanks for the review. I've updated the patch to allow consecutive mouse down events from different buttons and verified that it passes Daniel's test for this issue.(In reply to comment #0)
> The diff:
> 
> --- /home/slave/webkitgtk/gtk-linux-32-debug/build/layout-test-results/editing/selection/select-out-of-editable-expected.txt    2011-04-15 07:06:09.978467441 -0700
> +++ /home/slave/webkitgtk/gtk-linux-32-debug/build/layout-test-results/editing/selection/select-out-of-editable-actual.txt    2011-04-15 07:06:09.959742392 -0700
> @@ -1,4 +1,4 @@
>  hello world
> -Dragging to the left: PASS
> -Dragging to the left: PASS
> +Dragging to the left: FAIL - expected 0 but got 7
> +Dragging to the left: FAIL - expected 11 but got 10
> 
> I'll skip it for the moment.
Comment 7 Eric Seidel (no email) 2011-05-01 14:52:29 PDT 
Comment on attachment 91249 [details]
Updated patch with improved ChangeLog

View in context: https://bugs.webkit.org/attachment.cgi?id=91249&action=review

> Tools/DumpRenderTree/gtk/EventSender.cpp:65
> +static unsigned int buttonCurrentlyDown;

unsigned is all you need, not "int".
Comment 8 Martin Robinson 2011-05-02 09:23:15 PDT 
Comment on attachment 91249 [details]
Updated patch with improved ChangeLog

Clearing flags on attachment: 91249

Committed r85481: <http://trac.webkit.org/changeset/85481>
Comment 9 Martin Robinson 2011-05-02 09:23:18 PDT 
All reviewed patches have been landed.  Closing bug.