Bug 58655 - IndexedDB objectStoreNames not updated after aborted transaction
Summary: IndexedDB objectStoreNames not updated after aborted transaction
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Joshua Bell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-15 06:31 PDT by Mark Pilgrim (Google)
Modified: 2011-12-07 11:46 PST (History)
7 users (show)

See Also:


Attachments
test case (2.07 KB, text/html)
2011-04-15 06:32 PDT, Mark Pilgrim (Google)
no flags Details
Patch (4.33 KB, patch)
2011-11-23 15:02 PST, Joshua Bell
no flags Details | Formatted Diff | Diff
Patch (4.25 KB, patch)
2011-11-23 15:07 PST, Joshua Bell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2011-04-15 06:31:22 PDT
Original test: http://mxr.mozilla.org/mozilla2.0/source/dom/indexedDB/test/test_setVersion_abort.html?force=1

At the end of the test, the transaction is aborted and the object store should be removed (db.objectStoreNames.length should be 0). Mozilla correctly handles this, but WebKit still claims that objectStoreNames.length=1 and that objectStoreNames.item(0) is the name of the object store created during the now-aborted transaction.
Comment 1 Mark Pilgrim (Google) 2011-04-15 06:32:00 PDT
Created attachment 89775 [details]
test case
Comment 2 Joshua Bell 2011-11-23 15:02:19 PST
Created attachment 116433 [details]
Patch
Comment 3 Joshua Bell 2011-11-23 15:02:58 PST
This is already functional, but we didn't have a specific test. Adding the mozilla test c/o pilgrim@
Comment 4 David Grogan 2011-11-23 15:04:08 PST
Comment on attachment 116433 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116433&action=review

> LayoutTests/storage/indexeddb/mozilla/versionchange-abort.html:10
> +<link rel="stylesheet" href="../../../fast/js/resources/js-test-style.css">

We're not supposed to include this stylesheet anymore.
Comment 5 Joshua Bell 2011-11-23 15:07:07 PST
Created attachment 116435 [details]
Patch
Comment 6 Joshua Bell 2011-11-23 15:10:39 PST
Comment on attachment 116435 [details]
Patch

removed stylesheet link
Comment 7 Joshua Bell 2011-12-07 10:40:06 PST
tony@ - r? cq?
Comment 8 WebKit Review Bot 2011-12-07 11:46:14 PST
Comment on attachment 116435 [details]
Patch

Clearing flags on attachment: 116435

Committed r102260: <http://trac.webkit.org/changeset/102260>
Comment 9 WebKit Review Bot 2011-12-07 11:46:19 PST
All reviewed patches have been landed.  Closing bug.