Bug 58642 – CSP media-src is missing

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Adam Barth]

CSP media-src is missing

[Adam Barth]

Created attachment 89755 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 89755 [details]
Patch

Hmm.  Seems OK. why the stall in the tests?

[Eric Carlson]

Comment on attachment 89755 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89755&action=review

Is CSP supposed to work with local files as well? If so, we should have equivalent tests in LayoutTests/media.

> LayoutTests/http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt:2
> +END OF TEST
> +

Because it isn't possible to have an explicit "PASS" in the results, it would be nice to have some text to indicate what the constitutes success. I hate having to look at a test's source to figure out if it succeeded or failed.

[Adam Barth]

> Hmm.  Seems OK. why the stall in the tests?

It just comes from the test I copied.  I can try removing the stall.  I don't think it slows the test down in either case.

> Is CSP supposed to work with local files as well? If so, we should have equivalent tests in LayoutTests/media.

CSP can work with local files, yes.  I've only been testing it for the HTTP case, but I can add a local test if you like.

> > LayoutTests/http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt:2
> > +END OF TEST
> > +
> 
> Because it isn't possible to have an explicit "PASS" in the results, it would be nice to have some text to indicate what the constitutes success. I hate having to look at a test's source to figure out if it succeeded or failed.

Will do.

[Eric Carlson]

(In reply to comment #4)
> > Hmm.  Seems OK. why the stall in the tests?
> 
> It just comes from the test I copied.  I can try removing the stall.  I don't think it slows the test down in either case.
> 
It doesn't do anything in this case because the test ends when 'loadedmetadata' is fired.

[Adam Barth]

Created attachment 89852 [details]
Patch for landing

[Adam Barth]

The test fails if I remove the "stall" URL parameter.  Presumably there's a way to get rid of it, but it's not hurting anyone, so I've left it.

[WebKit Commit Bot]

Comment on attachment 89852 [details]
Patch for landing

Clearing flags on attachment: 89852

Committed r84077: <http://trac.webkit.org/changeset/84077>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/84077 might have broken Leopard Intel Debug (Tests)