Bug 58628 - Make mac WebKit1 use the default localization strategy
Summary: Make mac WebKit1 use the default localization strategy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-14 20:26 PDT by Sam Weinig
Modified: 2011-04-15 09:57 PDT (History)
0 users

See Also:


Attachments
Patch (50.13 KB, patch)
2011-04-14 20:29 PDT, Sam Weinig
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-04-14 20:26:24 PDT
Make mac WebKit1 use the default localization strategy
Comment 1 Sam Weinig 2011-04-14 20:29:26 PDT
Created attachment 89725 [details]
Patch
Comment 2 Maciej Stachowiak 2011-04-15 01:21:31 PDT
Comment on attachment 89725 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89725&action=review

r=me but see the  comments about comments.

> Source/WebCore/English.lproj/Localizable.strings:13
> -/* window title for a standalone image (uses multiplication symbol, not x) */
> +/* window title suffix for a standalone image (uses multiplication symbol, not x) */

It's not a suffix, it's a format string, so this comment change is not an improvement IMO.

> Source/WebCore/English.lproj/Localizable.strings:16
> -/* window title for a standalone image (uses multiplication symbol, not x) */
> +/* window title suffix for a standalone image (uses multiplication symbol, not x) */

It's not a suffix, it's a format string, so this comment change is not an improvement IMO.
Comment 3 Sam Weinig 2011-04-15 09:57:47 PDT
Committed r83985: <http://trac.webkit.org/changeset/83985>