Bug 58621 - Update webglcontextlost / webglcontextrestored delivery to match spec changes
Summary: Update webglcontextlost / webglcontextrestored delivery to match spec changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-14 18:19 PDT by Kenneth Russell
Modified: 2011-07-21 14:43 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.41 KB, patch)
2011-07-20 22:02 PDT, Kenneth Russell 		jamesr: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2011-04-14 18:19:28 PDT 
Based on feedback from Glenn Maynard, the WebGL spec was just updated to avoid side-effects of registering event handlers. Now, in order for webglcontextrestored to be delivered to the application, the developer must have registered a webglcontextlost handler, and that handler needs to call preventDefault() against the event object. WebKit's WebGL implementation needs to be updated to track this change, and ideally layout tests written using the WEBKIT_lose_context extension either created or updated.
Comment 1 Kenneth Russell 2011-07-20 22:02:36 PDT 
Created attachment 101556 [details]
Patch
Comment 2 James Robinson 2011-07-21 13:39:44 PDT 
Comment on attachment 101556 [details]
Patch

OK
Comment 3 Kenneth Russell 2011-07-21 14:43:19 PDT 
Committed r91504: <http://trac.webkit.org/changeset/91504>