Bug 58609 - IndexedDB put() should fail adding to object store that uses out-of-line keys and has no key generator and the key parameter was not provided
Summary: IndexedDB put() should fail adding to object store that uses out-of-line keys...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Nobody
URL:
Keywords:
: 58599 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-04-14 17:24 PDT by Mark Pilgrim (Google)
Modified: 2011-05-18 16:43 PDT (History)
6 users (show)

See Also:


Attachments
test case (1.65 KB, text/html)
2011-04-14 17:25 PDT, Mark Pilgrim (Google)
no flags Details
Patch (8.20 KB, patch)
2011-04-28 18:53 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2011-04-14 17:24:54 PDT
Original test at http://mxr.mozilla.org/mozilla2.0/source/dom/indexedDB/test/test_key_requirements.html?force=1#102 tests that Mozilla properly throws a DATA_ERR when calling put() with no second (key) parameter on an object store that was created with no keyPath (out-of-line keys) and no autoIncrement (key generator). According to http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#widl-IDBObjectStore-put

"""If any of the following conditions are true, this method throws a DATA_ERR exception: ... The object store uses out-of-line keys and has no key generator and the key parameter was not provided."""
Comment 1 Mark Pilgrim (Google) 2011-04-14 17:25:19 PDT
Created attachment 89696 [details]
test case
Comment 2 Mark Pilgrim (Google) 2011-04-28 18:53:00 PDT
Created attachment 91617 [details]
Patch
Comment 3 Mark Pilgrim (Google) 2011-04-28 19:01:38 PDT
*** Bug 58599 has been marked as a duplicate of this bug. ***
Comment 4 Hans Wennborg 2011-05-03 02:11:48 PDT
Unofficial r+.
Comment 5 David Grogan 2011-05-18 13:41:28 PDT
+tony for some r+ and cq+ action
Comment 6 WebKit Commit Bot 2011-05-18 16:43:35 PDT
Comment on attachment 91617 [details]
Patch

Clearing flags on attachment: 91617

Committed r86804: <http://trac.webkit.org/changeset/86804>
Comment 7 WebKit Commit Bot 2011-05-18 16:43:41 PDT
All reviewed patches have been landed.  Closing bug.