Bug 58596 - WK2: Past searches not remembered for <input type=search results="5" autosave="foo">
Summary: WK2: Past searches not remembered for <input type=search results="5" autosave...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-04-14 16:02 PDT by Brady Eidson
Modified: 2011-04-15 12:25 PDT (History)
0 users

See Also:

Attachments
Patch v1 (8.84 KB, patch)
2011-04-15 10:49 PDT, Brady Eidson 		mitz: review+
beidson: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2011-04-14 16:02:37 PDT 
Past searches not remembered for <input type=search results="5"> in WebKit2.

In radar as <rdar://problem/9287880>
Comment 1 Brady Eidson 2011-04-15 10:49:18 PDT 
Created attachment 89810 [details]
Patch v1
Comment 2 mitz 2011-04-15 12:11:34 PDT 
Comment on attachment 89810 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=89810&action=review

> Source/WebKit2/UIProcess/cf/WebPageProxyCF.cpp:191
> +    // The WebProcess shouldnt have bothered to send this message if the name was empty.

Typo: shouldnt.

> Source/WebKit2/UIProcess/cf/WebPageProxyCF.cpp:197
> +    size_t size = searchItems.size();
> +    if (size) {

size can be defined inside the if().

> Source/WebKit2/UIProcess/cf/WebPageProxyCF.cpp:211
> +    // The WebProcess shouldnt have bothered to send this message if the name was empty.

Same typo!!
Comment 3 Brady Eidson 2011-04-15 12:25:34 PDT 
r84011