Bug 58595 - Menu is not displayed for <input type=search results="5">
Summary: Menu is not displayed for <input type=search results="5">
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
Keywords: InRadar
Depends on:
Reported: 2011-04-14 16:01 PDT by Brady Eidson
Modified: 2011-04-14 16:13 PDT (History)
0 users

See Also:

Patch v1 (5.53 KB, patch)
2011-04-14 16:05 PDT, Brady Eidson
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2011-04-14 16:01:07 PDT
Menu is not displayed for <input type=search results="5">

The primary cause of the menu not even displaying is the WebSearchPopupMenu returned "false" for enabled.  That's a 1-liner.

I also included Mac-only code to get the Mac position correct.

Note that my planned fix for this won't actually implement setting/restoring the past searches - that's a logically separate task I'll track with another bug.

In radar as <rdar://problem/8665102>
Comment 1 Brady Eidson 2011-04-14 16:02:55 PDT
Adding the results memory is tracked in https://bugs.webkit.org/show_bug.cgi?id=58596
Comment 2 Brady Eidson 2011-04-14 16:05:29 PDT
Created attachment 89678 [details]
Patch v1
Comment 3 Brady Eidson 2011-04-14 16:13:43 PDT