Bug 58589 - commit-queue fails to catch IOError when results.html is missing
Summary: commit-queue fails to catch IOError when results.html is missing
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
Depends on:
Reported: 2011-04-14 15:48 PDT by Eric Seidel (no email)
Modified: 2011-04-14 15:56 PDT (History)
1 user (show)

See Also:

Patch (2.63 KB, patch)
2011-04-14 15:49 PDT, Eric Seidel (no email)
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2011-04-14 15:48:34 PDT
commit-queue fails to catch IOError when results.html is missing
Comment 1 Eric Seidel (no email) 2011-04-14 15:49:31 PDT
Created attachment 89675 [details]
Comment 2 Eric Seidel (no email) 2011-04-14 15:50:09 PDT
Traceback (most recent call last):
  File "/Projects/CommitQueue/Tools/Scripts/webkitpy/tool/bot/queueengine.py", line 108, in run
    if not self._delegate.process_work_item(work_item):
  File "/Projects/CommitQueue/Tools/Scripts/webkitpy/tool/commands/queues.py", line 281, in process_work_item
    if task.run():
  File "/Projects/CommitQueue/Tools/Scripts/webkitpy/tool/bot/commitqueuetask.py", line 252, in run
    if not self._test_patch():
  File "/Projects/CommitQueue/Tools/Scripts/webkitpy/tool/bot/commitqueuetask.py", line 189, in _test_patch
    if self._test():
  File "/Projects/CommitQueue/Tools/Scripts/webkitpy/tool/bot/commitqueuetask.py", line 149, in _test
    self._expected_failures.shrink_expected_failures(self._delegate.layout_test_results(), success)
  File "/Projects/CommitQueue/Tools/Scripts/webkitpy/tool/commands/queues.py", line 331, in layout_test_results
    results = self._create_layout_test_results()
  File "/Projects/CommitQueue/Tools/Scripts/webkitpy/tool/commands/queues.py", line 325, in _create_layout_test_results
    results_html = self._read_file_contents(results_path)
  File "/Projects/CommitQueue/Tools/Scripts/webkitpy/tool/commands/queues.py", line 318, in _read_file_contents
    return self._tool.filesystem.read_text_file(path)
  File "/Projects/CommitQueue/Tools/Scripts/webkitpy/common/system/filesystem.py", line 263, in read_text_file
    with codecs.open(path, 'r', 'utf8') as f:
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/codecs.py", line 865, in open
    file = __builtin__.open(filename, mode, buffering)
IOError: [Errno 2] No such file or directory: '/tmp/layout-test-results/results.html'

ORWT doesn't create a results.html file if all tests pass. :)
Comment 3 Eric Seidel (no email) 2011-04-14 15:56:16 PDT
Committed r83906: <http://trac.webkit.org/changeset/83906>