Bug 58583 - WebKit2: Password field input does not switch to ASCII-compatible source
Summary: WebKit2: Password field input does not switch to ASCII-compatible source
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.6
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-04-14 15:17 PDT by Alexey Proskuryakov
Modified: 2011-04-15 18:19 PDT (History)
5 users (show)

See Also:

Attachments
proposed fix (22.94 KB, patch)
2011-04-14 17:10 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
updated fix (23.00 KB, patch)
2011-04-15 10:43 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
also trying to fix chromium build (23.01 KB, patch)
2011-04-15 10:49 PDT, Alexey Proskuryakov 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2011-04-14 15:17:24 PDT 
And it also doesn't enable secure event mode.
Comment 1 Alexey Proskuryakov 2011-04-14 15:17:39 PDT 
<rdar://problem/9059651>
Comment 2 Alexey Proskuryakov 2011-04-14 17:10:44 PDT 
Created attachment 89690 [details]
proposed fix
Comment 3 Build Bot 2011-04-14 18:37:16 PDT 
Attachment 89690 [details] did not build on win:
Build output: http://queues.webkit.org/results/8442008
Comment 4 WebKit Review Bot 2011-04-15 02:00:30 PDT 
Attachment 89690 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8452094
Comment 5 mitz 2011-04-15 09:30:59 PDT 
Comment on attachment 89690 [details]
proposed fix

Looks okay but breaks some builds.
Comment 6 Alexey Proskuryakov 2011-04-15 10:43:14 PDT 
Created attachment 89808 [details]
updated fix

Mitz pointed out that WebPageProxy::selectionStateChanged() was wrong. I couldn't find any effect in testing, but it was wrong indeed.
Comment 7 Alexey Proskuryakov 2011-04-15 10:49:26 PDT 
Created attachment 89811 [details]
also trying to fix chromium build

Not sure why it failed, EWS doesn't save enough context, and doesn't stop the build after a failure (boo!).
Comment 8 Alexey Proskuryakov 2011-04-15 11:39:09 PDT 
Committed <http://trac.webkit.org/changeset/83997>.
Comment 9 WebKit Review Bot 2011-04-15 18:19:09 PDT 
http://trac.webkit.org/changeset/83997 might have broken GTK Linux 32-bit Debug
The following tests are not passing:
svg/W3C-SVG-1.1/animate-elem-82-t.svg