The vsnprintf is part of Microsoft C runtime. So, don't condition its use on COMPILER(MSVC), but on OS(WINDOWS)
Created attachment 89661 [details] Patch
As you say, the presence of vsnprintf depends on C runtime - so why is OS(WINDOWS) appropriate?
(In reply to comment #2) > As you say, the presence of vsnprintf depends on C runtime - so why is OS(WINDOWS) appropriate? Because the only relevant compilers out there and used by Webkit (MSVC and MinGW) link against the Microsoft C runtime
Created attachment 89744 [details] Modified patch: instead of OS(WINDOWS) test, add just COMPILER(MINGW) to that branch
(In reply to comment #2) > As you say, the presence of vsnprintf depends on C runtime - so why is OS(WINDOWS) appropriate? I modified the patch so that it only adds the COMPILER(MINGW) to the test. On a second thought, one can imagine a Windows compiler that comes with its own C runtime that is different from the Microsoft one.
Attachment 89744 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8452070
Created attachment 89745 [details] A new version of patch: removing accidental paste of unrelated garbage in the Source/WebCore/dom/XMLDocumentParserLibxml2.cpp
Attachment 89744 [details] did not build on win: Build output: http://queues.webkit.org/results/8452076
Comment on attachment 89745 [details] A new version of patch: removing accidental paste of unrelated garbage in the Source/WebCore/dom/XMLDocumentParserLibxml2.cpp Ok.
This one has a positive review. Anybody can put a nice "+" to the commit-queue too?
Comment on attachment 89745 [details] A new version of patch: removing accidental paste of unrelated garbage in the Source/WebCore/dom/XMLDocumentParserLibxml2.cpp cq+
Comment on attachment 89745 [details] A new version of patch: removing accidental paste of unrelated garbage in the Source/WebCore/dom/XMLDocumentParserLibxml2.cpp Clearing flags on attachment: 89745 Committed r85800: <http://trac.webkit.org/changeset/85800>
All reviewed patches have been landed. Closing bug.