WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
58570
Make creating WebPreferences lazy
https://bugs.webkit.org/show_bug.cgi?id=58570
Summary
Make creating WebPreferences lazy
Sam Weinig
Reported
2011-04-14 14:27:55 PDT
Make creating WebPreferences lazy
Attachments
Patch
(3.31 KB, patch)
2011-04-14 14:29 PDT
,
Sam Weinig
andersca
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2011-04-14 14:29:04 PDT
Created
attachment 89647
[details]
Patch
Anders Carlsson
Comment 2
2011-04-14 14:34:15 PDT
Comment on
attachment 89647
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=89647&action=review
> Source/WebKit2/ChangeLog:14 > + Don't create the WebPrefernece object until it is requested.
Typo
> Source/WebKit2/UIProcess/WebPageGroup.cpp:101 > + m_preferences->addPageGroup(this);
We don't need to call preferencesDidChange() here?
Sam Weinig
Comment 3
2011-04-14 14:39:30 PDT
Landed in
r83895
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug