Bug 58570 - Make creating WebPreferences lazy
Summary: Make creating WebPreferences lazy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-14 14:27 PDT by Sam Weinig
Modified: 2011-04-14 14:39 PDT (History)
0 users

See Also:

Attachments
Patch (3.31 KB, patch)
2011-04-14 14:29 PDT, Sam Weinig 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-04-14 14:27:55 PDT 
Make creating WebPreferences lazy
Comment 1 Sam Weinig 2011-04-14 14:29:04 PDT 
Created attachment 89647 [details]
Patch
Comment 2 Anders Carlsson 2011-04-14 14:34:15 PDT 
Comment on attachment 89647 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89647&action=review

> Source/WebKit2/ChangeLog:14
> +        Don't create the WebPrefernece object until it is requested.

Typo

> Source/WebKit2/UIProcess/WebPageGroup.cpp:101
> +        m_preferences->addPageGroup(this);

We don't need to call preferencesDidChange() here?
Comment 3 Sam Weinig 2011-04-14 14:39:30 PDT 
Landed in r83895.