RESOLVED FIXED 58561
Enable building Web Audio with MKL in Chrome-branded builds 
https://bugs.webkit.org/show_bug.cgi?id=58561
Summary Enable building Web Audio with MKL in Chrome-branded builds
Kenneth Russell
Reported 2011-04-14 12:15:58 PDT
Chrome-branded builds on Windows and Linux should now use the MKL port of the FFTFrame class. The hacks in WebCore.gyp to enable linking against both the MKL and FFTW need to be removed.
Attachments
Patch (7.80 KB, patch)
2011-04-14 13:07 PDT, Kenneth Russell 		dglazkov: review+
kbr: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Rogers
Comment 1 2011-04-14 12:58:59 PDT
We might want to consider keeping the FFTW path, even though it is not actually used, if it doesn't complicate WebCore.gyp too much
Kenneth Russell
Comment 2 2011-04-14 13:03:00 PDT
OK, I'll leave the FFTW path in WebCore.gyp.
Kenneth Russell
Comment 3 2011-04-14 13:07:05 PDT
Created attachment 89633 [details] Patch
Kenneth Russell
Comment 4 2011-04-14 13:08:23 PDT
Note that one more change in the Chromium workspace (in features_override.gypi) is needed in order for this patch to have any effect on Windows or Linux. Currently ENABLE_WEBAUDIO=0 on those platforms.
Dimitri Glazkov (Google)
Comment 5 2011-04-14 13:54:58 PDT
Comment on attachment 89633 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89633&action=review > Source/WebCore/platform/audio/fftw/FFTFrameFFTW.cpp:30 > +#if ENABLE(WEB_AUDIO) && !OS(DARWIN) && USE(WEBAUDIO_FFTW) Can you separate the additional conditionals into a separate define? > Source/WebCore/platform/audio/mkl/FFTFrameMKL.cpp:31 > +#if ENABLE(WEB_AUDIO) && !OS(DARWIN) && USE(WEBAUDIO_MKL) Ditto.
Kenneth Russell
Comment 6 2011-04-14 13:59:18 PDT
(In reply to comment #5) > (From update of attachment 89633 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=89633&action=review > > > Source/WebCore/platform/audio/fftw/FFTFrameFFTW.cpp:30 > > +#if ENABLE(WEB_AUDIO) && !OS(DARWIN) && USE(WEBAUDIO_FFTW) > > Can you separate the additional conditionals into a separate define? > > > Source/WebCore/platform/audio/mkl/FFTFrameMKL.cpp:31 > > +#if ENABLE(WEB_AUDIO) && !OS(DARWIN) && USE(WEBAUDIO_MKL) > > Ditto. Yes, will do. Thanks.
Kenneth Russell
Comment 7 2011-04-14 14:02:06 PDT
Committed r83893: <http://trac.webkit.org/changeset/83893>
Note You need to log in before you can comment on or make changes to this bug.