Bug 58556 - [Qt] GraphicsContext3D::getImageData() does not retrieve image data correctly
Summary: [Qt] GraphicsContext3D::getImageData() does not retrieve image data correctly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-14 11:13 PDT by Jarkko Sakkinen
Modified: 2011-05-10 13:32 PDT (History)
4 users (show)

See Also:


Attachments
layout test diff (1.38 KB, text/plain)
2011-04-14 23:07 PDT, Jarkko Sakkinen
no flags Details
Load image data when it is unloaded. (2.51 KB, patch)
2011-05-06 06:19 PDT, Jarkko Sakkinen
no flags Details | Formatted Diff | Diff
Fixed line formatting for packPixels (now everything is in single source code line): (2.64 KB, patch)
2011-05-06 06:25 PDT, Jarkko Sakkinen
kenneth: review+
kenneth: commit-queue+
Details | Formatted Diff | Diff
reinterpret_cast (2.66 KB, patch)
2011-05-08 04:49 PDT, Jarkko Sakkinen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jarkko Sakkinen 2011-04-14 11:13:21 PDT
Failing test case:
LayoutTests/fast/canvas/webgl/gl-teximage.html
Comment 1 Jarkko Sakkinen 2011-04-14 11:14:48 PDT
I'm preparing a fix for this.
Comment 2 Jarkko Sakkinen 2011-04-14 23:07:00 PDT
Created attachment 89740 [details]
layout test diff

The layout test has now 100% pass rate but the diff is different (see the attachment).
Comment 3 Jarkko Sakkinen 2011-05-06 06:19:46 PDT
Created attachment 92576 [details]
Load image data when it is unloaded.
Comment 4 Jarkko Sakkinen 2011-05-06 06:25:42 PDT
Created attachment 92578 [details]
Fixed line formatting for packPixels (now everything is in single source code line):
Comment 5 Kenneth Rohde Christiansen 2011-05-07 04:50:45 PDT
Comment on attachment 92578 [details]
Fixed line formatting for packPixels (now everything is in single source code line):

should this be up for review?
Comment 6 Jarkko Sakkinen 2011-05-08 04:43:02 PDT
Yes. Forgot to update attachment flags :)
Comment 7 Jarkko Sakkinen 2011-05-08 04:49:41 PDT
Created attachment 92736 [details]
reinterpret_cast
Comment 8 WebKit Commit Bot 2011-05-08 05:19:03 PDT
Comment on attachment 92736 [details]
reinterpret_cast

Clearing flags on attachment: 92736

Committed r86026: <http://trac.webkit.org/changeset/86026>
Comment 9 WebKit Commit Bot 2011-05-08 05:19:08 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Ademar Reis 2011-05-10 13:32:02 PDT
Revision r86026 cherry-picked into qtwebkit-2.2 with commit 9226105 <http://gitorious.org/webkit/qtwebkit/commit/9226105>