Bug 58544 - Don't emit RegExp tables for chromium where they are not used
Summary: Don't emit RegExp tables for chromium where they are not used
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-14 08:01 PDT by Satish Sampath
Modified: 2011-04-14 08:48 PDT (History)
0 users

See Also:

Attachments
Patch (2.76 KB, patch)
2011-04-14 08:03 PDT, Satish Sampath 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Satish Sampath 2011-04-14 08:01:34 PDT 
The character tables generated by the create_regex_tables script are used only by the Yarr (Yet another regex runtime) JIT feature. Since the chromium port does not use the Yarr JIT feature, we don't need these tables in the generated code.
Comment 1 Satish Sampath 2011-04-14 08:03:30 PDT 
Created attachment 89583 [details]
Patch
Comment 2 Anders Carlsson 2011-04-14 08:16:57 PDT 
Comment on attachment 89583 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89583&action=review

> Source/JavaScriptCore/create_regex_tables:38
> +emitTables = (len(sys.argv) < 2 or sys.argv[1] != "--notables")

Could we call this --no-tables instead?
Comment 3 Satish Sampath 2011-04-14 08:48:00 PDT 
Committed r83860: <http://trac.webkit.org/changeset/83860>