Bug 58538 - Web Inspector: fix de-obfuscation of scripts inlined in html.
Summary: Web Inspector: fix de-obfuscation of scripts inlined in html.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-14 06:44 PDT by Pavel Podivilov
Modified: 2011-04-22 09:48 PDT (History)
13 users (show)

See Also:


Attachments
Patch. (27.03 KB, patch)
2011-04-14 06:45 PDT, Pavel Podivilov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2011-04-14 06:44:20 PDT
Web Inspector: fix de-obfuscation of scripts inlined in html.

Currently we use script positions from scriptParsed notifications from backend. This doesn't work very well:
1. Some scripts may already be collected when frontend is opened.
2. Sometimes scripts come after resource is finished, so we are forced to rebuild content for each scriptParsed event.

More robust solution would be to use html tokenizer to find script boundaries.
Comment 1 Pavel Podivilov 2011-04-14 06:45:39 PDT
Created attachment 89576 [details]
Patch.
Comment 2 Pavel Podivilov 2011-04-22 06:51:49 PDT
Committed r84625: <http://trac.webkit.org/changeset/84625>
Comment 3 WebKit Review Bot 2011-04-22 09:48:48 PDT
http://trac.webkit.org/changeset/84625 might have broken GTK Linux 32-bit Debug