Bug 58537 – Web Inspector: TAB should not move focus from the text editor while live editing

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Andrey Adaikin]

Seems like we should override the native behavior for the TAB key.

[Andrey Adaikin]

Created attachment 89791 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 89791 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89791&action=review

> Source/WebCore/inspector/front-end/TextViewer.js:243
> +        var handleUndo = this._mainPanel.handleUndoRedo.bind(this._mainPanel, 0);

Why do we prefer 0/1 to false/true here?

> Source/WebCore/inspector/front-end/TextViewer.js:951
> +        this._setCaretLocation(newRange.endLine, newRange.endColumn);

Shouldn't we scroll the viewer to the new caret location?

[Andrey Adaikin]

Done. Diff to apply before the commit:


diff --git a/Source/WebCore/inspector/front-end/TextViewer.js b/Source/WebCore/inspector/front-end/TextViewer.js
index 09c3092..8f823cf 100644
--- a/Source/WebCore/inspector/front-end/TextViewer.js
+++ b/Source/WebCore/inspector/front-end/TextViewer.js
@@ -240,13 +240,13 @@ WebInspector.TextViewer.prototype = {
         this._shortcuts[WebInspector.KeyboardShortcut.makeKey(keys.Enter.code, modifiers.CtrlOrMeta)] = commitEditing;
         this._shortcuts[WebInspector.KeyboardShortcut.makeKey(keys.Esc.code)] = cancelEditing;
 
-        var handleUndo = this._mainPanel.handleUndoRedo.bind(this._mainPanel, 0);
-        var handleRedo = this._mainPanel.handleUndoRedo.bind(this._mainPanel, 1);
+        var handleUndo = this._mainPanel.handleUndoRedo.bind(this._mainPanel, false);
+        var handleRedo = this._mainPanel.handleUndoRedo.bind(this._mainPanel, true);
         this._shortcuts[WebInspector.KeyboardShortcut.makeKey("z", modifiers.CtrlOrMeta)] = handleUndo;
         this._shortcuts[WebInspector.KeyboardShortcut.makeKey("z", modifiers.Shift | modifiers.CtrlOrMeta)] = handleRedo;
 
-        var handleTabKey = this._mainPanel.handleTabKeyPress.bind(this._mainPanel, 0);
-        var handleShiftTabKey = this._mainPanel.handleTabKeyPress.bind(this._mainPanel, 1);
+        var handleTabKey = this._mainPanel.handleTabKeyPress.bind(this._mainPanel, false);
+        var handleShiftTabKey = this._mainPanel.handleTabKeyPress.bind(this._mainPanel, true);
         this._shortcuts[WebInspector.KeyboardShortcut.makeKey(keys.Tab.code)] = handleTabKey;
         this._shortcuts[WebInspector.KeyboardShortcut.makeKey(keys.Tab.code, modifiers.Shift)] = handleShiftTabKey;
     },
@@ -948,7 +948,7 @@ WebInspector.TextEditorMainPanel.prototype = {
         this._exitTextChangeMode(range, newRange);
         this.endUpdates();
 
-        this._setCaretLocation(newRange.endLine, newRange.endColumn);
+        this._setCaretLocation(newRange.endLine, newRange.endColumn, true);
         return true;
     },

[Andrey Adaikin]

Created attachment 90022 [details]
Patch

[WebKit Review Bot]

Comment on attachment 90022 [details]
Patch

Rejecting attachment 90022 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Commit Bot]

Comment on attachment 90022 [details]
Patch

Clearing flags on attachment: 90022

Committed r84136: <http://trac.webkit.org/changeset/84136>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/84136 might have broken Windows 7 Release (Tests)
The following tests are not passing:
http/tests/inspector/resource-tree-model.html