Bug 58518 - BlobBuilder should be vendor-prefixed
: BlobBuilder should be vendor-prefixed
Status: RESOLVED FIXED
: WebKit
WebCore Misc.
: 528+ (Nightly build)
: PC Mac OS X 10.5
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2011-04-13 23:28 PST by
Modified: 2011-04-17 22:45 PST (History)


Attachments
Proposed Patch (70.47 KB, patch)
2011-04-14 13:01 PST, Jian Li
fishd: review+
jianli: commit‑queue-
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-04-13 23:28:33 PST
Since FileWriter API is not yet standard, we should vendor-prefix BlobBuilder.
(As for FileWriter it cannot be created without requesting FileSystem, whose entry point will be prefixed as well, we won't need to prefix it separately.)

window.BlobBuilder -> window.webkitBlobBuilder
------- Comment #1 From 2011-04-14 08:59:14 PST -------
Shouldn't it be WebKitBlobBuilder, like WebKitPoint?  Things you can construct start with an upper-case letter, right?
------- Comment #2 From 2011-04-14 13:01:27 PST -------
Created an attachment (id=89631) [details]
Proposed Patch
------- Comment #3 From 2011-04-17 22:45:17 PST -------
Submitted: http://trac.webkit.org/changeset/83884