Bug 58518 - BlobBuilder should be vendor-prefixed
: BlobBuilder should be vendor-prefixed
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebCore Misc.
: 528+ (Nightly build)
: PC Mac OS X 10.5
: P2 Normal
Assigned To: Jian Li
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-04-13 23:28 PDT by Kinuko Yasuda
Modified: 2011-04-17 22:45 PDT (History)
3 users (show)

See Also:


Attachments
Proposed Patch (70.47 KB, patch)
2011-04-14 13:01 PDT, Jian Li
fishd: review+
jianli: commit‑queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kinuko Yasuda 2011-04-13 23:28:33 PDT
Since FileWriter API is not yet standard, we should vendor-prefix BlobBuilder.
(As for FileWriter it cannot be created without requesting FileSystem, whose entry point will be prefixed as well, we won't need to prefix it separately.)

window.BlobBuilder -> window.webkitBlobBuilder
Comment 1 Darin Fisher (:fishd, Google) 2011-04-14 08:59:14 PDT
Shouldn't it be WebKitBlobBuilder, like WebKitPoint?  Things you can construct start with an upper-case letter, right?
Comment 2 Jian Li 2011-04-14 13:01:27 PDT
Created attachment 89631 [details]
Proposed Patch
Comment 3 Kinuko Yasuda 2011-04-17 22:45:17 PDT
Submitted: http://trac.webkit.org/changeset/83884