Since FileSystem API is not standard yet and will likely change, we should vendor-prefix the exposed API. Specifically: window.requestFileSystem should be renamed to window.webkitRequestFileSystem.
I guess following APIs should also be prefixed? window.resolveLocalFileSystemURL WorkerContext.requestFileSystem WorkerContext.requestFileSystemSync WorkerContext.resolveLocalFileSystemURL WorkerContext.resolveLocalFileSystemSyncURL
Created attachment 89557 [details] Patch
Comment on attachment 89557 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89557&action=review > Source/WebCore/ChangeLog:6 > + https://bugs.webkit.org/show_bug.cgi?id=58517 Looks good, thanks for working on this. I think it'd be better to add some explanation why and how (which method) we're prefixing in the ChangeLog. (Probably you can just copy and paste the explanation from the bug.)
Comment on attachment 89557 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89557&action=review > Source/WebCore/page/DOMWindow.idl:200 > attribute [EnabledAtRuntime=FileSystem] FlagsConstructor Flags; What about Flags? Should this be WebKitFlags for completeness? (I think it is OK to leave TEMPORARY and PERSISTENT as is... just not sure about Flags.)
Comment on attachment 89557 [details] Patch What about the flags TEMPORARY and PERSISTENT? Should we prefix them too?
(In reply to comment #5) > (From update of attachment 89557 [details]) > What about the flags TEMPORARY and PERSISTENT? Should we prefix them too? Sorry--missed your comment. Nevermind.
Created attachment 89982 [details] Patch
Attachment 89982 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8459821
Attachment 89982 [details] did not build on win: Build output: http://queues.webkit.org/results/8459825
Attachment 89982 [details] did not build on qt: Build output: http://queues.webkit.org/results/8435870
Created attachment 89992 [details] Patch
Attachment 89992 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8442874
Attachment 89992 [details] did not build on win: Build output: http://queues.webkit.org/results/8459854
Created attachment 89995 [details] Patch
Created attachment 89996 [details] Patch
Created attachment 89999 [details] Patch
(In reply to comment #16) > Created an attachment (id=89999) [details] > Patch Thanks for working on this. The patch looks good to me. (Could any 'real' reviewer take a look at the patch?)
Comment on attachment 89999 [details] Patch Clearing flags on attachment: 89999 Committed r84224: <http://trac.webkit.org/changeset/84224>
All reviewed patches have been landed. Closing bug.