Bug 58514 - Creating a CairoPath instance is not thread safe
Summary: Creating a CairoPath instance is not thread safe
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Joone Hur
Keywords: Cairo
Depends on:
Reported: 2011-04-13 22:46 PDT by Joone Hur
Modified: 2011-04-15 15:58 PDT (History)
5 users (show)

See Also:

Proposed Patch (9.34 KB, patch)
2011-04-14 01:17 PDT, Joone Hur
mrobinson: review+
Details | Formatted Diff | Diff
Updated Patch (9.71 KB, patch)
2011-04-14 10:08 PDT, Joone Hur
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joone Hur 2011-04-13 22:46:38 PDT
Creating a CairoPath instance is not thread safe.
Comment 1 Joone Hur 2011-04-14 01:17:27 PDT
Created attachment 89546 [details]
Proposed Patch

I applied the following comment to this patch.
Comment 2 Martin Robinson 2011-04-14 08:12:47 PDT
Comment on attachment 89546 [details]
Proposed Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89546&action=review

Looks good. Please move the two new files to PlatformPathCairo.* before landing. Thanks!

> Source/WebCore/CMakeListsEfl.txt:94
> +    platform/graphics/cairo/PlatformCairoPath.cpp
>      platform/graphics/cairo/PlatformContextCairo.cpp

Probably better to name it PlatformPathCairo to match PlatformContextCairo.

> Source/WebCore/platform/graphics/cairo/PlatformCairoPath.h:22
> +#ifndef PlatformCairoPath_h
> +#define PlatformCairoPath_h

Don't forget to update these header guards when you move this to PlatformPathCairo.

> Source/WebCore/platform/graphics/cairo/PlatformCairoPath.h:35
> +    ~CairoPath()
> +    {
> +    }

You can place this on one line just like context().

> Source/WebCore/platform/graphics/cairo/PlatformCairoPath.h:45
> +#endif // CairoPath_h

Don't forget to update this header guard.
Comment 3 Joone Hur 2011-04-14 10:08:33 PDT
Created attachment 89602 [details]
Updated Patch

Thanks, Martin for the review.
Comment 4 WebKit Commit Bot 2011-04-14 22:18:20 PDT
Comment on attachment 89602 [details]
Updated Patch

Clearing flags on attachment: 89602

Committed r83945: <http://trac.webkit.org/changeset/83945>
Comment 5 WebKit Commit Bot 2011-04-14 22:18:25 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Brent Fulgham 2011-04-15 15:58:59 PDT
Correction for WinCairo build:

Please watch out for new files that are not added to the Visual Studio projects!

Committed r84044: <http://trac.webkit.org/changeset/84044>