Bug 58514 – Creating a CairoPath instance is not thread safe

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Joone Hur]

Creating a CairoPath instance is not thread safe.

[Joone Hur]

Created attachment 89546 [details]
Proposed Patch

I applied the following comment to this patch.
https://bugs.webkit.org/show_bug.cgi?id=57717#c23

[Martin Robinson]

Comment on attachment 89546 [details]
Proposed Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89546&action=review

Looks good. Please move the two new files to PlatformPathCairo.* before landing. Thanks!

> Source/WebCore/CMakeListsEfl.txt:94
> +    platform/graphics/cairo/PlatformCairoPath.cpp
>      platform/graphics/cairo/PlatformContextCairo.cpp

Probably better to name it PlatformPathCairo to match PlatformContextCairo.

> Source/WebCore/platform/graphics/cairo/PlatformCairoPath.h:22
> +#ifndef PlatformCairoPath_h
> +#define PlatformCairoPath_h

Don't forget to update these header guards when you move this to PlatformPathCairo.

> Source/WebCore/platform/graphics/cairo/PlatformCairoPath.h:35
> +    ~CairoPath()
> +    {
> +    }

You can place this on one line just like context().

> Source/WebCore/platform/graphics/cairo/PlatformCairoPath.h:45
> +#endif // CairoPath_h

Don't forget to update this header guard.

[Joone Hur]

Created attachment 89602 [details]
Updated Patch

Thanks, Martin for the review.

[WebKit Commit Bot]

Comment on attachment 89602 [details]
Updated Patch

Clearing flags on attachment: 89602

Committed r83945: <http://trac.webkit.org/changeset/83945>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Brent Fulgham]

Correction for WinCairo build:

Please watch out for new files that are not added to the Visual Studio projects!

Committed r84044: <http://trac.webkit.org/changeset/84044>