Bug 58512 - Calls to WebCore::Document::mayCauseFlashOfUnstyledContent make frequently-run drawing methods slower
Summary: Calls to WebCore::Document::mayCauseFlashOfUnstyledContent make frequently-ru...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh Intel OS X 10.6
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2011-04-13 21:58 PDT by Ian Henderson
Modified: 2011-04-15 17:49 PDT (History)
6 users (show)

See Also:

Patch (5.93 KB, patch)
2011-04-15 17:29 PDT, Hajime Morrita
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Henderson 2011-04-13 21:58:37 PDT
In https://bugs.webkit.org/show_bug.cgi?id=45640, we added a more complicated heuristic to determine whether drawing may cause a flash of unstyled content.  The WebCore::Document::mayCauseFlashOfUnstyledContent method is called during every WebCore::RenderBlock::paintContents and WebCore::RenderLayer::paintLayer, both of which may be called many times on a complex page.  The additional complexity adds measurable overhead to these methods.
Comment 1 Hajime Morrita 2011-04-14 09:59:27 PDT
Okay, I'll remove mayCauseFlashOfUnstyledContent() usage.
I'd like to keep mayCauseFlashOfUnstyledContent() definition to possibly use it
on browser's paint() side, instead of preventing repaint() as we are doing now.
Comment 2 Hajime Morrita 2011-04-15 17:29:23 PDT
Created attachment 89891 [details]
Comment 3 Hajime Morrita 2011-04-15 17:29:59 PDT
I changed my mind to just roll it out.
Comment 4 Hajime Morrita 2011-04-15 17:49:36 PDT
Committed r84066: <http://trac.webkit.org/changeset/84066>