RESOLVED FIXED 58512
Calls to WebCore::Document::mayCauseFlashOfUnstyledContent make frequently-run drawing methods slower 
https://bugs.webkit.org/show_bug.cgi?id=58512
Summary Calls to WebCore::Document::mayCauseFlashOfUnstyledContent make frequently-ru...
Ian Henderson
Reported Thursday, April 14, 2011 5:58:37 AM UTC
In https://bugs.webkit.org/show_bug.cgi?id=45640, we added a more complicated heuristic to determine whether drawing may cause a flash of unstyled content. The WebCore::Document::mayCauseFlashOfUnstyledContent method is called during every WebCore::RenderBlock::paintContents and WebCore::RenderLayer::paintLayer, both of which may be called many times on a complex page. The additional complexity adds measurable overhead to these methods.
Attachments
Patch (5.93 KB, patch)
2011-04-15 17:29 PDT, Hajime Morrita 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hajime Morrita
Comment 1 Thursday, April 14, 2011 5:59:27 PM UTC
Okay, I'll remove mayCauseFlashOfUnstyledContent() usage. I'd like to keep mayCauseFlashOfUnstyledContent() definition to possibly use it on browser's paint() side, instead of preventing repaint() as we are doing now.
Hajime Morrita
Comment 2 Saturday, April 16, 2011 1:29:23 AM UTC
Created attachment 89891 [details] Patch
Hajime Morrita
Comment 3 Saturday, April 16, 2011 1:29:59 AM UTC
I changed my mind to just roll it out.
Hajime Morrita
Comment 4 Saturday, April 16, 2011 1:49:36 AM UTC
Committed r84066: <http://trac.webkit.org/changeset/84066>
Note You need to log in before you can comment on or make changes to this bug.