RESOLVED FIXED Bug 58510
webkit-patch upload failed on new binary files 
https://bugs.webkit.org/show_bug.cgi?id=58510
Summary webkit-patch upload failed on new binary files
Simon Fraser (smfr)
Reported 2011-04-13 21:42:08 PDT
Doing a 'webkit-patch upload' on some local (staged) changes in my git repo that included new PNG files failed with: Exception raised during decoding git binary patch: can't convert nil into String /Volumes/Monster/Development/apple/webkit/WebKit.git/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:538:in `pack' /Volumes/Monster/Development/apple/webkit/WebKit.git/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:538:in `initialize' /Volumes/Monster/Development/apple/webkit/WebKit.git/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:538:in `collect' /Volumes/Monster/Development/apple/webkit/WebKit.git/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:538:in `initialize' /Volumes/Monster/Development/apple/webkit/WebKit.git/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:603:in `new' /Volumes/Monster/Development/apple/webkit/WebKit.git/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:603:in `parse' /Volumes/Monster/Development/apple/webkit/WebKit.git/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:603:in `collect' /Volumes/Monster/Development/apple/webkit/WebKit.git/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:603:in `parse' /Volumes/Monster/Development/apple/webkit/WebKit.git/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:16:in `prettify' /Volumes/Monster/Development/apple/webkit/WebKit.git/Websites/bugs.webkit.org/PrettyPatch/prettify.rb:26
Attachments
PrettyPatch output (287.94 KB, text/plain)
2011-04-13 21:42 PDT, Simon Fraser (smfr) 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2011-04-13 21:42:30 PDT
Created attachment 89528 [details] PrettyPatch output
Simon Fraser (smfr)
Comment 2 2011-04-13 21:43:43 PDT
The PNG files are missing from the patch: https://bugs.webkit.org/attachment.cgi?id=89529&action=review
Simon Fraser (smfr)
Comment 3 2011-04-13 21:54:01 PDT
The actual patch is at https://bug-58457-attachments.webkit.org/attachment.cgi?id=89529
Simon Fraser (smfr)
Comment 4 2011-04-13 22:02:11 PDT
This was caused by http://trac.webkit.org/changeset/83750
Simon Fraser (smfr)
Comment 5 2011-04-13 22:06:19 PDT
http://trac.webkit.org/changeset/83811
Tony Chang
Comment 6 2011-04-14 09:55:20 PDT
Sorry for the breakage and thanks for rolling out.
Note You need to log in before you can comment on or make changes to this bug.