Bug 58489 - [NRWT] Rename --baseline-search-patch to --additional-platform-directory to match ORWT
Summary: [NRWT] Rename --baseline-search-patch to --additional-platform-directory to m...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Mihai Parparita
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-13 15:30 PDT by Mihai Parparita
Modified: 2011-04-13 16:04 PDT (History)
3 users (show)

See Also:

Attachments
Patch (7.39 KB, patch)
2011-04-13 15:32 PDT, Mihai Parparita 		no flags Details | Formatted Diff | Diff
Patch (7.39 KB, patch)
2011-04-13 15:57 PDT, Mihai Parparita 		eric: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mihai Parparita 2011-04-13 15:30:28 PDT 
[NRWT] Rename --baseline-search-patch to --additional-platform-directory to match ORWT
Comment 1 Mihai Parparita 2011-04-13 15:32:32 PDT 
Created attachment 89480 [details]
Patch
Comment 2 Dirk Pranke 2011-04-13 15:39:25 PDT 
Comment on attachment 89480 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89480&action=review

> Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py:257
> +        # Multiple additional paltform directories

Nit: typo "paltform"
Comment 3 Dirk Pranke 2011-04-13 15:39:38 PDT 
Looks fine otherwise.
Comment 4 Mihai Parparita 2011-04-13 15:57:00 PDT 
Created attachment 89484 [details]
Patch
Comment 5 Mihai Parparita 2011-04-13 15:57:14 PDT 
(In reply to comment #2)
> Nit: typo "paltform"

Fixed.
Comment 6 Eric Seidel (no email) 2011-04-13 16:01:41 PDT 
Comment on attachment 89484 [details]
Patch

OK.  How many chromium bots will this break? :)
Comment 7 Mihai Parparita 2011-04-13 16:02:16 PDT 
(In reply to comment #6)
> (From update of attachment 89484 [details])
> OK.  How many chromium bots will this break? :)

0, since no bots use it yet :)
Comment 8 Mihai Parparita 2011-04-13 16:04:14 PDT 
Committed r83783: <http://trac.webkit.org/changeset/83783>