Bug 58457 - Some borders with border-radius do not have rounded inner edges
Summary: Some borders with border-radius do not have rounded inner edges
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Blocker
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-13 10:58 PDT by Simon Fraser (smfr)
Modified: 2011-04-17 09:44 PDT (History)
8 users (show)

See Also:

Attachments
Testcase (1.19 KB, text/html)
2011-04-13 10:58 PDT, Simon Fraser (smfr) 		no flags Details
Screenshot: Firefox (left) vs. WebKit (right) (163.22 KB, image/png)
2011-04-13 10:58 PDT, Simon Fraser (smfr) 		no flags Details
Screenshot: Firefox (left) vs. WebKit (right) (181.90 KB, image/png)
2011-04-13 13:51 PDT, Simon Fraser (smfr) 		no flags Details
Patch (200.84 KB, text/plain)
2011-04-13 21:42 PDT, Simon Fraser (smfr) 		no flags Details
Patch (200.74 KB, patch)
2011-04-13 22:25 PDT, Simon Fraser (smfr) 		bdakin: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2011-04-13 10:58:20 PDT 
Created attachment 89401 [details]
Testcase

See attached testcase and screenshot; WebKit does a really poor job of rendering some rounded borders.
Comment 1 Simon Fraser (smfr) 2011-04-13 10:58:52 PDT 
Created attachment 89402 [details]
Screenshot: Firefox (left) vs. WebKit (right)
Comment 2 Simon Fraser (smfr) 2011-04-13 13:51:04 PDT 
Created attachment 89449 [details]
Screenshot: Firefox (left) vs. WebKit (right)

In previous screenshot, WebKit was patched.
Comment 3 Simon Fraser (smfr) 2011-04-13 21:42:55 PDT 
Created attachment 89529 [details]
Patch
Comment 4 WebKit Review Bot 2011-04-13 22:08:23 PDT 
Attachment 89529 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8401569
Comment 5 Simon Fraser (smfr) 2011-04-13 22:23:40 PDT 
Comment on attachment 89529 [details]
Patch

Will fix cr-linux
Comment 6 Simon Fraser (smfr) 2011-04-13 22:25:09 PDT 
Created attachment 89532 [details]
Patch
Comment 7 Beth Dakin 2011-04-14 12:46:45 PDT 
Comment on attachment 89532 [details]
Patch

I feel like this code could use more comments. r=me.
Comment 8 WebKit Review Bot 2011-04-15 18:19:13 PDT 
http://trac.webkit.org/changeset/83998 might have broken GTK Linux 32-bit Debug
The following tests are not passing:
svg/W3C-SVG-1.1/animate-elem-82-t.svg
Comment 9 Simon Fraser (smfr) 2011-04-17 09:44:00 PDT 
http://trac.webkit.org/changeset/83998