WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
58446
ORWT needs a way to look in a user-specified directory for platform-specific results
https://bugs.webkit.org/show_bug.cgi?id=58446
Summary
ORWT needs a way to look in a user-specified directory for platform-specific ...
Adam Roben (:aroben)
Reported
2011-04-13 08:59:58 PDT
ORWT needs a way to look in a user-specified directory for platform-specific results
Attachments
Patch
(2.75 KB, patch)
2011-04-13 09:01 PDT
,
Adam Roben (:aroben)
andersca
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1
2011-04-13 09:01:30 PDT
Created
attachment 89383
[details]
Patch
Adam Roben (:aroben)
Comment 2
2011-04-13 09:06:49 PDT
CCing Dirk since he is working on NRWT/ORWT parity.
Adam Roben (:aroben)
Comment 3
2011-04-13 09:12:44 PDT
Committed
r83743
: <
http://trac.webkit.org/changeset/83743
>
Dirk Pranke
Comment 4
2011-04-13 14:37:59 PDT
Heh, we actually added this to NRWT in
r82972
, except that we called it --baseline-search-path. It would be good if we actually used the same parameter name. I don't have a strong leaning either way, but I might like --additional-platform-directory a bit more. Mihai, what do you think?
Mihai Parparita
Comment 5
2011-04-13 14:44:23 PDT
Does --additional-platform-directory only let you specify directories inside LayoutTests/platform? The intent with --baseline-search-path was to allow local (not under version control) directories to be used too, and it made sense for those to live outside the LayoutTests tree.
Adam Roben (:aroben)
Comment 6
2011-04-13 14:48:09 PDT
(In reply to
comment #5
)
> Does --additional-platform-directory only let you specify directories inside LayoutTests/platform? The intent with --baseline-search-path was to allow local (not under version control) directories to be used too, and it made sense for those to live outside the LayoutTests tree.
The directory does not have to be within LayoutTests/platform.
Mihai Parparita
Comment 7
2011-04-13 14:50:12 PDT
(In reply to
comment #6
)
> The directory does not have to be within LayoutTests/platform.
OK, will rename --baseline-search-path then.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug