Bug 58446 - ORWT needs a way to look in a user-specified directory for platform-specific results
Summary: ORWT needs a way to look in a user-specified directory for platform-specific ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-13 08:59 PDT by Adam Roben (:aroben)
Modified: 2011-04-13 14:50 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.75 KB, patch)
2011-04-13 09:01 PDT, Adam Roben (:aroben) 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-04-13 08:59:58 PDT 
ORWT needs a way to look in a user-specified directory for platform-specific results
Comment 1 Adam Roben (:aroben) 2011-04-13 09:01:30 PDT 
Created attachment 89383 [details]
Patch
Comment 2 Adam Roben (:aroben) 2011-04-13 09:06:49 PDT 
CCing Dirk since he is working on NRWT/ORWT parity.
Comment 3 Adam Roben (:aroben) 2011-04-13 09:12:44 PDT 
Committed r83743: <http://trac.webkit.org/changeset/83743>
Comment 4 Dirk Pranke 2011-04-13 14:37:59 PDT 
Heh, we actually added this to NRWT in r82972, except that we called it --baseline-search-path. It would be good if we actually used the same parameter name. I don't have a strong leaning either way, but I might like --additional-platform-directory a bit more.

Mihai, what do you think?
Comment 5 Mihai Parparita 2011-04-13 14:44:23 PDT 
Does --additional-platform-directory only let you specify directories inside LayoutTests/platform? The intent with --baseline-search-path was to allow local (not under version control) directories to be used too, and it made sense for those to live outside the LayoutTests tree.
Comment 6 Adam Roben (:aroben) 2011-04-13 14:48:09 PDT 
(In reply to comment #5)
> Does --additional-platform-directory only let you specify directories inside LayoutTests/platform? The intent with --baseline-search-path was to allow local (not under version control) directories to be used too, and it made sense for those to live outside the LayoutTests tree.

The directory does not have to be within LayoutTests/platform.
Comment 7 Mihai Parparita 2011-04-13 14:50:12 PDT 
(In reply to comment #6)
> The directory does not have to be within LayoutTests/platform.

OK, will rename --baseline-search-path then.