Bug 58442 – video controls have no-longer-necessary bottom placement on media documents

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Ami Fischman]

Video controls in media documents should look the same as ones in HTML files, namely overlap the video canvas.  Not only is that required for consistency, it's also necessary in order to reason about the height of the rendered <video> element, which can be useful in iframes, for example.

[Ami Fischman]

Created attachment 89378 [details]
Remove bogus bottom margin from media-document video controls.

[Jer Noble]

The bottom margin for full page media is there for a reason: so the controls do not overlap the video during playback.  As such, it's not "bogus" but a intentional design decision by Apple's HI department.  Any changes which affect the to the look-and-feel of the media controls will just get reverted.

Please find another way to achieve what you are trying to do here.

[Jer Noble]

Ah, I've been told that I'm misinformed.  The original reason for putting the controls under the video was because previously controls couldn't be rendered over the video.  I actually fixed that bug recently, so there is no longer an impediment to rendering the controls over the video area.  HI will get used to it. :)

[Jer Noble]

Still, the decision wasn't "bogus" but completely necessary at the time.

[Jer Noble]

Anyway, objection withdrawn. :)

[Eric Carlson]

Comment on attachment 89378 [details]
Remove bogus bottom margin from media-document video controls.

View in context: https://bugs.webkit.org/attachment.cgi?id=89378&action=review

r- only because I think it would be good to have a more accurate descriptions in the change log.

> Source/WebCore/ChangeLog:5
> +        Remove the bogus bottom margin of controls in video elements on media documents.

"bogus" is incorrect, how about "unnecessary" instead?

[Ami Fischman]

Created attachment 89391 [details]
Stop harshing historical mellow.

[Ami Fischman]

Amended ChangeLog and rephrased the bug summary to be more reflective of reality.
Sorry for my previous phrasing.

[WebKit Commit Bot]

Comment on attachment 89391 [details]
Stop harshing historical mellow.

Rejecting attachment 89391 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sf', 'bu..." exit_code: 2

Last 500 characters of output:
ests/xmlhttprequest ................................................................................................................................................................................
http/tests/xmlhttprequest/web-apps ...............
http/tests/xmlhttprequest/workers ...........
http/tests/xmlviewer .
http/tests/xmlviewer/dumpAsText ............
754.05s total testing time

23268 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
16 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/8397557

[WebKit Commit Bot]

Created attachment 89549 [details]
Archive of layout-test-results from eseidel-cq-sf

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: eseidel-cq-sf  Port: Mac  Platform: Mac OS X 10.6.4

[Ami Fischman]

Created attachment 89588 [details]
Update for single (!) failing layout test.

[WebKit Commit Bot]

Comment on attachment 89588 [details]
Update for single (!) failing layout test.

Clearing flags on attachment: 89588

Committed r83939: <http://trac.webkit.org/changeset/83939>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.