RESOLVED FIXED 58432
Change the representation of ShadowRoot nodes in render tree dumps 
https://bugs.webkit.org/show_bug.cgi?id=58432
Summary Change the representation of ShadowRoot nodes in render tree dumps
Kent Tamura
Reported 2011-04-13 04:40:38 PDT
We had better show ShadowRoot nodes explicitly in render tree dumps instead of showing #document-fragment. Example: Editing range dump: -EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 0 of DIV > #document-fragment to 0 of DIV > #document-fragment affinity:NSSelectionAffinityDownstream stillSelecting:FALSE +EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 0 of DIV > #shadow-root to 0 of DIV > #shadow-root affinity:NSSelectionAffinityDownstream stillSelecting:FALSE Caret dump: -caret: position 0 of child 0 {DIV} of child 0 {#document-fragment} of child 1 {INPUT} of child 3 {DIV} of body +caret: position 0 of child 0 {DIV} of {#shadow-root} of child 1 {INPUT} of child 3 {DIV} of body Selection dump: -selection start: position 0 of child 0 {#text} of child 0 {DIV} of child 0 {#document-fragment} of child 3 {INPUT} of child 1 {P} of body -selection end: position 15 of child 0 {#text} of child 0 {DIV} of child 0 {#document-fragment} of child 3 {INPUT} of child 1 {P} of body +selection start: position 0 of child 0 {#text} of child 0 {DIV} of {#shadow-root} of child 3 {INPUT} of child 1 {P} of body +selection end: position 15 of child 0 {#text} of child 0 {DIV} of {#shadow-root} of child 3 {INPUT} of child 1 {P} of body
Attachments
Patch (3.60 KB, patch)
2011-04-13 05:26 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2011-04-13 05:26:31 PDT
Created attachment 89366 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2011-04-13 09:19:47 PDT
Comment on attachment 89366 [details] Patch ok.
Dimitri Glazkov (Google)
Comment 3 2011-04-13 09:20:10 PDT
Roland, you might be interested in seeing this.
WebKit Commit Bot
Comment 4 2011-04-13 18:12:03 PDT
Comment on attachment 89366 [details] Patch Clearing flags on attachment: 89366 Committed r83796: <http://trac.webkit.org/changeset/83796>
WebKit Commit Bot
Comment 5 2011-04-13 18:12:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.