Bug 58432 - Change the representation of ShadowRoot nodes in render tree dumps
Summary: Change the representation of ShadowRoot nodes in render tree dumps
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Minor
Assignee: Kent Tamura
URL:
Keywords:
Depends on: 57813
Blocks: 54179
  Show dependency treegraph
 
Reported: 2011-04-13 04:40 PDT by Kent Tamura
Modified: 2011-04-13 18:12 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.60 KB, patch)
2011-04-13 05:26 PDT, Kent Tamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2011-04-13 04:40:38 PDT
We had better show ShadowRoot nodes explicitly in render tree dumps instead of showing #document-fragment.

Example:
Editing range dump:
-EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 0 of DIV > #document-fragment to 0 of DIV > #document-fragment affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 0 of DIV > #shadow-root to 0 of DIV > #shadow-root affinity:NSSelectionAffinityDownstream stillSelecting:FALSE

Caret dump:
-caret: position 0 of child 0 {DIV} of child 0 {#document-fragment} of child 1 {INPUT} of child 3 {DIV} of body
+caret: position 0 of child 0 {DIV} of {#shadow-root} of child 1 {INPUT} of child 3 {DIV} of body

Selection dump:
-selection start: position 0 of child 0 {#text} of child 0 {DIV} of child 0 {#document-fragment} of child 3 {INPUT} of child 1 {P} of body
-selection end:   position 15 of child 0 {#text} of child 0 {DIV} of child 0 {#document-fragment} of child 3 {INPUT} of child 1 {P} of body
+selection start: position 0 of child 0 {#text} of child 0 {DIV} of {#shadow-root} of child 3 {INPUT} of child 1 {P} of body
+selection end:   position 15 of child 0 {#text} of child 0 {DIV} of {#shadow-root} of child 3 {INPUT} of child 1 {P} of body
Comment 1 Kent Tamura 2011-04-13 05:26:31 PDT
Created attachment 89366 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2011-04-13 09:19:47 PDT
Comment on attachment 89366 [details]
Patch

ok.
Comment 3 Dimitri Glazkov (Google) 2011-04-13 09:20:10 PDT
Roland, you might be interested in seeing this.
Comment 4 WebKit Commit Bot 2011-04-13 18:12:03 PDT
Comment on attachment 89366 [details]
Patch

Clearing flags on attachment: 89366

Committed r83796: <http://trac.webkit.org/changeset/83796>
Comment 5 WebKit Commit Bot 2011-04-13 18:12:08 PDT
All reviewed patches have been landed.  Closing bug.