WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
58431
[GTK] Consider editable and non editable nodes when calculating selection offsets
https://bugs.webkit.org/show_bug.cgi?id=58431
Summary
[GTK] Consider editable and non editable nodes when calculating selection off...
Mario Sanchez Prada
Reported
2011-04-13 04:26:32 PDT
This bug is just to track a simple -yet needed- change in AccessibilityObjectWrapperAtk.cpp: replace usage of firstPositionInNode() with firstPositionInOrBeforeNode(), as well as lastPositionInNode() with lastPositionInOrAfterNode(). This is needed to ensure that the function getSelectionOffsetsForObject() works well both when non editable nodes can be present in the selection, since firstPositionInNode() and lastPositionInNode() don't work in those cases (they assume the node is editable).
Attachments
Patch proposal
(3.33 KB, patch)
2011-04-13 04:29 PDT
,
Mario Sanchez Prada
mrobinson
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mario Sanchez Prada
Comment 1
2011-04-13 04:29:09 PDT
Created
attachment 89364
[details]
Patch proposal Attached patch proposal. Both API and Layout tests keep passing.
Martin Robinson
Comment 2
2011-04-13 08:25:20 PDT
Comment on
attachment 89364
[details]
Patch proposal View in context:
https://bugs.webkit.org/attachment.cgi?id=89364&action=review
> Source/WebCore/ChangeLog:8 > + Use firstPositionInOrBeforeNode() and lastPositionInOrAfterNode().
Why not put the second paragraph of the bug description here? It will be useful for people looks through Trac or git.
Mario Sanchez Prada
Comment 3
2011-04-13 09:33:19 PDT
Committed
r83747
: <
http://trac.webkit.org/changeset/83747
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug