Bug 58427 - [CMAKE] Separate DerivedSources.
Summary: [CMAKE] Separate DerivedSources.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 2000
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-13 02:58 PDT by Ryuan Choi
Modified: 2011-04-13 17:45 PDT (History)
8 users (show)

See Also:

Attachments
Patch (28.69 KB, patch)
2011-04-13 03:09 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2011-04-13 02:58:36 PDT 
Other ports build generated sources for different components in different directories but CMake doesn't.
Comment 1 Patrick R. Gansterer 2011-04-13 03:00:22 PDT 
I did this change already on my box when building the apple win32 port with windows.
If you have not done this already I can generate y patch and upload it here.
Comment 2 Ryuan Choi 2011-04-13 03:09:42 PDT 
Created attachment 89359 [details]
Patch
Comment 3 Ryuan Choi 2011-04-13 03:12:33 PDT 
(In reply to comment #1)
> I did this change already on my box when building the apple win32 port with windows.
> If you have not done this already I can generate y patch and upload it here.

Sorry, I didn't see your message.
I checked on EFL port. but you can mark as a duplicated if you did.
Comment 4 Patrick R. Gansterer 2011-04-13 03:20:17 PDT 
(In reply to comment #3)
> (In reply to comment #1)
> > I did this change already on my box when building the apple win32 port with windows.
> > If you have not done this already I can generate y patch and upload it here.
> 
> Sorry, I didn't see your message.
> I checked on EFL port. but you can mark as a duplicated if you did.
I only did it locally, so you can't know of it. ;-)
Patch LGTM.
Comment 5 Lucas De Marchi 2011-04-13 07:56:17 PDT 
LGTM too. Kenneth, can you rubber stamp it?
Comment 6 WebKit Commit Bot 2011-04-13 17:44:56 PDT 
Comment on attachment 89359 [details]
Patch

Clearing flags on attachment: 89359

Committed r83792: <http://trac.webkit.org/changeset/83792>
Comment 7 WebKit Commit Bot 2011-04-13 17:45:00 PDT 
All reviewed patches have been landed.  Closing bug.