Bug 58423 - Web Inspector: [REGRESSION] diffs in resource revisions are not displayed.
Summary: Web Inspector: [REGRESSION] diffs in resource revisions are not displayed.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-13 02:26 PDT by Pavel Feldman
Modified: 2011-04-13 04:39 PDT (History)
10 users (show)

See Also:


Attachments
Patch. (3.18 KB, patch)
2011-04-13 04:30 PDT, Pavel Podivilov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-04-13 02:26:57 PDT
Try editing css file live, save it multiple times. No clue on what has changed.
Comment 1 Pavel Podivilov 2011-04-13 04:30:27 PDT
Created attachment 89365 [details]
Patch.
Comment 2 Pavel Feldman 2011-04-13 04:32:06 PDT
Comment on attachment 89365 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=89365&action=review

> Source/WebCore/inspector/front-end/ResourceView.js:202
> +            callback("Stylesheet not found.");

Should you return empty content instead?
Comment 3 Pavel Podivilov 2011-04-13 04:34:42 PDT
(In reply to comment #2)
> (From update of attachment 89365 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=89365&action=review
> 
> > Source/WebCore/inspector/front-end/ResourceView.js:202
> > +            callback("Stylesheet not found.");
> 
> Should you return empty content instead?

This callback doesn't return content, it just notifies TextViewer whether new text was committed or rejected.
Comment 4 Pavel Podivilov 2011-04-13 04:39:15 PDT
Committed r83719: <http://trac.webkit.org/changeset/83719>