Bug 58422 - [REGRESSION] A::before content not clickable
Summary: [REGRESSION] A::before content not clickable
Status: RESOLVED DUPLICATE of bug 91723
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Normal
Assignee: Nobody
Keywords: InRadar
: 60543 (view as bug list)
Depends on:
Reported: 2011-04-13 02:26 PDT by Pavel Feldman
Modified: 2013-03-01 18:06 PST (History)
18 users (show)

See Also:

[HTML] Reduced test case (228 bytes, text/html)
2011-04-13 07:31 PDT, Alexander Pavlov (apavlov)
no flags Details
Proposed Patch. (8.09 KB, patch)
2011-05-23 18:34 PDT, Kulanthaivel Palanichamy
no flags Details | Formatted Diff | Diff
Proposed Patch. (8.91 KB, patch)
2011-05-24 12:33 PDT, Kulanthaivel Palanichamy
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-02 (1.20 MB, application/zip)
2011-05-24 14:32 PDT, WebKit Review Bot
no flags Details
Proposed Patch. (8.91 KB, patch)
2011-05-24 17:43 PDT, Kulanthaivel Palanichamy
hyatt: review-
Details | Formatted Diff | Diff
Proposed Patch V2. (7.20 KB, patch)
2011-05-26 11:12 PDT, Kulanthaivel Palanichamy
hyatt: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-04-13 02:26:06 PDT
Open webkit.org, navigate to a css using sidebar. Broken!
Comment 1 Alexander Pavlov (apavlov) 2011-04-13 07:29:55 PDT
This is a regression from http://trac.webkit.org/changeset/83075
Comment 2 Alexander Pavlov (apavlov) 2011-04-13 07:31:17 PDT
Created attachment 89374 [details]
[HTML] Reduced test case
Comment 3 Alexander Pavlov (apavlov) 2011-04-13 07:35:38 PDT
Mouse events on A::before content should be handled the same way as on the A content.
Comment 4 Alexey Proskuryakov 2011-04-13 11:24:49 PDT
Comment 5 Alexander Pavlov (apavlov) 2011-04-14 05:13:58 PDT
As a regression, it should be P1.
Comment 6 Julien Chaffraix 2011-05-23 18:09:05 PDT
*** Bug 60543 has been marked as a duplicate of this bug. ***
Comment 7 Kulanthaivel Palanichamy 2011-05-23 18:34:21 PDT
Created attachment 94539 [details]
Proposed Patch.
Comment 8 Kulanthaivel Palanichamy 2011-05-24 12:33:53 PDT
Created attachment 94667 [details]
Proposed Patch.

Missed out a layout test image resource in my previous patch.
Comment 9 WebKit Review Bot 2011-05-24 14:32:08 PDT
Comment on attachment 94667 [details]
Proposed Patch.

Attachment 94667 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8727694

New failing tests:
Comment 10 WebKit Review Bot 2011-05-24 14:32:13 PDT
Created attachment 94689 [details]
Archive of layout-test-results from ec2-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02  Port: Chromium  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 11 Kulanthaivel Palanichamy 2011-05-24 17:43:52 PDT
Created attachment 94722 [details]
Proposed Patch.

Fixed the expected test result.
Comment 12 Dave Hyatt 2011-05-25 11:20:47 PDT
Comment on attachment 94722 [details]
Proposed Patch.

I don't think this should be necessary.  If you don't have a node you should just be moving up the line box tree to parents (and/or the RenderObject tree to parents).  You shouldn't need a special bit just to identify generated content.
Comment 13 Kulanthaivel Palanichamy 2011-05-26 11:12:08 PDT
Created attachment 95007 [details]
Proposed Patch V2.
Comment 14 Alexander Pavlov (apavlov) 2011-06-14 09:05:42 PDT
@reviewers: ping. This bug breaks a few bits of Web Inspector...
Comment 15 Pavel Feldman 2011-06-14 09:06:01 PDT
There is another report on this issue: 

This time, error circle next to the error count in console is not clickable (it is also implemented as ::before).
Comment 16 Alexander Pavlov (apavlov) 2011-07-05 01:20:58 PDT
@reviewers: anyone?
Comment 17 Dave Hyatt 2011-07-19 17:47:19 PDT
Comment on attachment 95007 [details]
Proposed Patch V2.

This isn't quite right. You want something narrower. I suspect you could move the code from addNodeToRectBasedTestResult to updateHitTestResult to fix this bug.
Comment 18 Alexander Pavlov (apavlov) 2011-10-26 05:08:50 PDT
Chromium issue: http://code.google.com/p/chromium/issues/detail?id=82888
Comment 19 luctiemessen 2012-08-28 01:24:57 PDT
Is this bug still under development?
I am pretty new to this bug filing stuff but it seems the previous comment is referring to a chromium bug report that seems to be fixed but I am still getting this bug.
Comment 20 Alexander Pavlov (apavlov) 2012-08-28 04:52:39 PDT
The Chromium bugfix is a workaround of this issue, so this one is still valid and is waiting for someone to fix it.
Comment 21 Martin Robinson 2013-03-01 18:06:43 PST

*** This bug has been marked as a duplicate of bug 91723 ***