Bug 58407 - Make PropertyMapEntry use a WriteBarrier for specificValue
Summary: Make PropertyMapEntry use a WriteBarrier for specificValue
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-12 18:33 PDT by Oliver Hunt
Modified: 2011-04-13 11:53 PDT (History)
2 users (show)

See Also:

Attachments
Patch (75.38 KB, patch)
2011-04-12 18:35 PDT, Oliver Hunt 		no flags Details | Formatted Diff | Diff
Patch (77.58 KB, patch)
2011-04-12 21:21 PDT, Oliver Hunt 		no flags Details | Formatted Diff | Diff
Patch (78.23 KB, patch)
2011-04-12 22:50 PDT, Oliver Hunt 		no flags Details | Formatted Diff | Diff
Patch (79.22 KB, patch)
2011-04-13 08:34 PDT, Oliver Hunt 		no flags Details | Formatted Diff | Diff
Patch (80.03 KB, patch)
2011-04-13 10:09 PDT, Oliver Hunt 		barraclough: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2011-04-12 18:33:10 PDT 
Make PropertyMapEntry use a WriteBarrier for specificValue
Comment 1 Oliver Hunt 2011-04-12 18:35:02 PDT 
Created attachment 89323 [details]
Patch
Comment 2 WebKit Review Bot 2011-04-12 18:38:10 PDT 
Attachment 89323 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSClassRef.cpp',..." exit_code: 1

Source/JavaScriptCore/runtime/Structure.h:146:  The parameter name "mode" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2011-04-12 19:53:16 PDT 
Attachment 89323 [details] did not build on win:
Build output: http://queues.webkit.org/results/8398116
Comment 4 Oliver Hunt 2011-04-12 21:21:06 PDT 
Created attachment 89334 [details]
Patch
Comment 5 WebKit Review Bot 2011-04-12 21:23:12 PDT 
Attachment 89334 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSClassRef.cpp',..." exit_code: 1

Source/JavaScriptCore/runtime/Structure.h:146:  The parameter name "mode" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Build Bot 2011-04-12 21:49:23 PDT 
Attachment 89334 [details] did not build on win:
Build output: http://queues.webkit.org/results/8400185
Comment 7 Oliver Hunt 2011-04-12 22:50:14 PDT 
Created attachment 89342 [details]
Patch
Comment 8 WebKit Review Bot 2011-04-12 22:53:07 PDT 
Attachment 89342 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSClassRef.cpp',..." exit_code: 1

Source/JavaScriptCore/runtime/Structure.h:146:  The parameter name "mode" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Build Bot 2011-04-12 23:58:03 PDT 
Attachment 89342 [details] did not build on win:
Build output: http://queues.webkit.org/results/8400229
Comment 10 Build Bot 2011-04-13 00:27:32 PDT 
Attachment 89342 [details] did not build on win:
Build output: http://queues.webkit.org/results/8403160
Comment 11 Oliver Hunt 2011-04-13 08:34:36 PDT 
Created attachment 89381 [details]
Patch
Comment 12 WebKit Review Bot 2011-04-13 08:37:23 PDT 
Attachment 89381 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSClassRef.cpp',..." exit_code: 1

Source/JavaScriptCore/runtime/Structure.h:146:  The parameter name "mode" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 13 Build Bot 2011-04-13 09:42:41 PDT 
Attachment 89381 [details] did not build on win:
Build output: http://queues.webkit.org/results/8403268
Comment 14 Oliver Hunt 2011-04-13 10:09:11 PDT 
Created attachment 89394 [details]
Patch
Comment 15 WebKit Review Bot 2011-04-13 10:11:25 PDT 
Attachment 89394 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSClassRef.cpp',..." exit_code: 1

Source/JavaScriptCore/runtime/Structure.h:146:  The parameter name "mode" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 16 Gavin Barraclough 2011-04-13 11:34:38 PDT 
Comment on attachment 89394 [details]
Patch

Might be worth adding a comment re the PropertyTable code being non- write barrier correct.
Comment 17 Oliver Hunt 2011-04-13 11:53:19 PDT 
Committed r83751: <http://trac.webkit.org/changeset/83751>