The method onEndChain should be renamed and should become static.
Thanks.
Created attachment 89316 [details] Patch.
Comment on attachment 89316 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=89316&action=review Otherwise LGTM. If you're a committer, you can just add the two keywords when you land, otherwise you'll need to post a new patch. Thanks! > Source/WebCore/rendering/InlineFlowBox.cpp:255 > +bool isLastChildForRenderer(RenderObject* ancestor, RenderObject* child) Should mark it static and possibly inline.
(In reply to comment #3) > (From update of attachment 89316 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=89316&action=review > > Otherwise LGTM. If you're a committer, you can just add the two keywords when you land, otherwise you'll need to post a new patch. Thanks! > > > Source/WebCore/rendering/InlineFlowBox.cpp:255 > > +bool isLastChildForRenderer(RenderObject* ancestor, RenderObject* child) > > Should mark it static and possibly inline. Terribly sorry, I forgot to mark it static. Thanks for catching it. I'll mark it inline if the compiler agrees :)
Committed r83679: <http://trac.webkit.org/changeset/83679>