Bug 58399 - Web Inspector: Timeline is too narrow
Summary: Web Inspector: Timeline is too narrow
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-12 17:16 PDT by Annie Sullivan
Modified: 2011-04-22 03:05 PDT (History)
11 users (show)

See Also:


Attachments
Firebug vs Web Inspector Net panel widths (499.79 KB, image/png)
2011-04-12 17:16 PDT, Annie Sullivan
no flags Details
Patch (6.52 KB, patch)
2011-04-14 15:52 PDT, Annie Sullivan
no flags Details | Formatted Diff | Diff
New patch, fixes changelog (7.90 KB, patch)
2011-04-14 16:30 PDT, Annie Sullivan
pfeldman: review+
Details | Formatted Diff | Diff
Screenshot of network panel before patch (424.45 KB, image/png)
2011-04-14 17:15 PDT, Annie Sullivan
no flags Details
Screenshot of Network Panel after patch (425.05 KB, image/png)
2011-04-14 17:17 PDT, Annie Sullivan
no flags Details
New patch, addresses review comments (8.16 KB, patch)
2011-04-15 13:00 PDT, Annie Sullivan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Annie Sullivan 2011-04-12 17:16:31 PDT
Created attachment 89312 [details]
Firebug vs Web Inspector Net panel widths

The timeline column in the network pane is only 30% of the width, making it a bit hard to read. It should be wider, like Firebug (which appears to be 50%).
Comment 1 Timothy Hatcher 2011-04-12 17:38:38 PDT
That reminds me. We never added the "collapse the shaded columns button" that was agreed upon when this issue was brought up in the beginning.
Comment 2 Annie Sullivan 2011-04-14 15:52:47 PDT
Created attachment 89676 [details]
Patch
Comment 3 Alexander Pavlov (apavlov) 2011-04-14 16:15:34 PDT
Comment on attachment 89676 [details]
Patch

This patch needs a ChangeLog entry, according to http://www.webkit.org/coding/contributing.html
Comment 4 Annie Sullivan 2011-04-14 16:30:26 PDT
Created attachment 89681 [details]
New patch, fixes changelog
Comment 5 Timothy Hatcher 2011-04-14 16:35:44 PDT
We still should add a colapse button.
Comment 6 Annie Sullivan 2011-04-14 16:41:35 PDT
Yes, we should still add a button to collapse shaded columns. Filed bug 58602 for that.
Comment 7 Annie Sullivan 2011-04-14 17:15:52 PDT
Created attachment 89693 [details]
Screenshot of network panel before patch
Comment 8 Annie Sullivan 2011-04-14 17:17:01 PDT
Created attachment 89694 [details]
Screenshot of Network Panel after patch

I couldn't figure out how to make tooltips display while I was taking a screenshot, but if you hover the mouse over a narrower column, you get a tooltip with the column text.
Comment 9 Pavel Feldman 2011-04-14 21:20:00 PDT
Comment on attachment 89681 [details]
New patch, fixes changelog

View in context: https://bugs.webkit.org/attachment.cgi?id=89681&action=review

This looks good, thanks for doing it.

> Source/WebCore/ChangeLog:5
> +        Changed Network Panel widths so that Timeline is 50%.

It should be:

WebInspector: Title
http://...
<optional blank line>
Multiline description here.

Changes digest.

> Source/WebCore/inspector/front-end/NetworkPanel.js:960
> +            widths.timeline = 50;

It leaves 5% left, is that intentional? Did you check whether column resize bars are aligned properly?

> Source/WebCore/inspector/front-end/NetworkPanel.js:1436
> +    _setTextAndTitle: function(element, text)

You could define setTextAndTitle on Elements' prototype in the utilities.js.
Comment 10 Annie Sullivan 2011-04-15 12:59:17 PDT
Comment on attachment 89681 [details]
New patch, fixes changelog

View in context: https://bugs.webkit.org/attachment.cgi?id=89681&action=review

>> Source/WebCore/ChangeLog:5
>> +        Changed Network Panel widths so that Timeline is 50%.
> 
> It should be:
> 
> WebInspector: Title
> http://...
> <optional blank line>
> Multiline description here.
> 
> Changes digest.

Done.

>> Source/WebCore/inspector/front-end/NetworkPanel.js:960
>> +            widths.timeline = 50;
> 
> It leaves 5% left, is that intentional? Did you check whether column resize bars are aligned properly?

Oops, miscounted the number of columns. Changed so it sums correctly to 100%. Column resize bars are aligned properly, at least after the change.

>> Source/WebCore/inspector/front-end/NetworkPanel.js:1436
>> +    _setTextAndTitle: function(element, text)
> 
> You could define setTextAndTitle on Elements' prototype in the utilities.js.

Done.
Comment 11 Annie Sullivan 2011-04-15 13:00:21 PDT
Created attachment 89837 [details]
New patch, addresses review comments
Comment 12 WebKit Commit Bot 2011-04-22 03:05:07 PDT
Comment on attachment 89837 [details]
New patch, addresses review comments

Clearing flags on attachment: 89837

Committed r84614: <http://trac.webkit.org/changeset/84614>
Comment 13 WebKit Commit Bot 2011-04-22 03:05:15 PDT
All reviewed patches have been landed.  Closing bug.